core(render-blocking-resources): add FCP and LCP savings #15238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
reviewed
Jul 10, 2023
| @@ -299,6 +299,7 @@ class RenderBlockingResources extends Audit { | |||
| numericValue: wastedMs, | |||
| numericUnit: 'millisecond', | |||
| details, | |||
| metricSavings: {FCP: wastedMs, LCP: wastedMs}, | |||
There was a problem hiding this comment.
Using the existing wastedMs makes sense for now, but wastedMs is computed using the FCP graph. I do wonder if computing a second LCP wastedMs with the LCP graph would also be useful.
This requires more investigation, so I'll open a separate issue to track this.
There was a problem hiding this comment.
ah something like what we have to do with uses-rel-preconnect?
separate issue sounds good to me!
There was a problem hiding this comment.
Yeah, I imagine we'll copy the FCP implementation for LCP and see how big the difference is.
adamraine
approved these changes
Jul 10, 2023
|
Smoke test failures look unrelated :/ |
adamraine
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.