core(render-blocking-resources): add FCP and LCP savings (#15238)

GoogleChrome · Jul 11, 2023 · 4ce741a · 4ce741a
1 parent 2bd5e7e
commit 4ce741a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/core/audits/byte-efficiency/render-blocking-resources.js b/core/audits/byte-efficiency/render-blocking-resources.js
@@ -299,6 +299,7 @@ class RenderBlockingResources extends Audit {
       numericValue: wastedMs,
       numericUnit: 'millisecond',
       details,
+      metricSavings: {FCP: wastedMs, LCP: wastedMs},
     };
   }
 }

diff --git a/core/test/audits/byte-efficiency/render-blocking-resources-test.js b/core/test/audits/byte-efficiency/render-blocking-resources-test.js
@@ -41,6 +41,7 @@ describe('Render blocking resources audit', () => {
     const result = await RenderBlockingResourcesAudit.audit(artifacts, {settings, computedCache});
     assert.equal(result.score, 1);
     assert.equal(result.numericValue, 0);
+    assert.deepStrictEqual(result.metricSavings, {FCP: 0, LCP: 0});
   });
 
   it('evaluates amp page correctly', async () => {
@@ -87,6 +88,7 @@ describe('Render blocking resources audit', () => {
       // it look like Montserrat starts after Fira Sans finishes. It would be preferred
       // if eventual simulation improvements list Montserrat here as well.
     ]);
+    expect(result.metricSavings).toEqual({FCP: 450, LCP: 450});
   });
 
   describe('#estimateSavingsWithGraphs', () => {