Skip to content

Minor fixes to manifest #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 20, 2023
Merged

Minor fixes to manifest #64

merged 3 commits into from
Jan 20, 2023

Conversation

@ithinkandicode
Copy link
Collaborator

Fixes a few bits where .mod_manifest was used instead of .manifest

Also fixes the get_mod_config func not working. It still needs an update, but this stops it crashing

@ithinkandicode ithinkandicode requested a review from Qubus0 January 20, 2023 00:29
Qubus0
Qubus0 approved these changes Jan 20, 2023
View reviewed changes
Copy link
Collaborator

@Qubus0 Qubus0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We need to increase type safety to avoid this stuff

@ithinkandicode ithinkandicode merged commit e67c7f7 into GodotModding:main Jan 20, 2023
@ithinkandicode ithinkandicode deleted the fix-manifest branch February 3, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Qubus0 Qubus0 Qubus0 approved these changes

@otDan otDan otDan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ithinkandicode @Qubus0 @otDan