Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes to manifest #64

Merged
merged 3 commits into from
Jan 20, 2023
Merged

Minor fixes to manifest #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
02a9643
fix use of `.mod_manifest` instead of `.manifest`
ithinkandicode Jan 20, 2023
abf530e
fix missing `config_defaults`
ithinkandicode Jan 20, 2023
806f826
fix `config_defaults` using wrong property
ithinkandicode Jan 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions addons/mod_loader/mod_loader.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ func _check_dependencies(mod_id:String, deps:Array):
continue

var dependency = mod_data[dependency_id]
var dependency_mod_manifest = mod_data[dependency_id].mod_manifest
var dependency_mod_manifest = mod_data[dependency_id].manifest

# Init the importance score if it's missing

Expand Down Expand Up @@ -497,7 +497,7 @@ func get_mod_config(mod_id:String = "", key:String = "")->Dictionary:
# Mod ID is valid
if error_num == 0:
var config_data = mod_data[mod_id].config
defaults = mod_data[mod_id].mod_manifest.extra.godot.config_defaults
defaults = mod_data[mod_id].manifest.config_defaults

# No custom JSON file
if config_data.size() == 0:
Expand Down
2 changes: 2 additions & 0 deletions addons/mod_loader/mod_manifest.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ var compatible_game_version := [] # Array[String]
# only used for information
var incompatibilities := [] # Array[String]
var tags := [] # Array[String]
var config_defaults := [] # Array[String]
var description_rich := ""
var image: StreamTexture

Expand Down Expand Up @@ -74,6 +75,7 @@ func _init(manifest: Dictionary) -> void:
compatible_game_version = _get_array_from_dict(godot_details, "compatible_game_version")
description_rich = _get_string_from_dict(godot_details, "description_rich")
tags = _get_array_from_dict(godot_details, "tags")
config_defaults = _get_array_from_dict(godot_details, "config_defaults")

# todo load file named icon.png when loading mods and use here
# image StreamTexture
Expand Down