Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v6.0.2 #310

Merged
merged 4 commits into from
Jul 1, 2023
Merged

v6.0.2 #310

merged 4 commits into from
Jul 1, 2023

Conversation

KANAjetzt
Copy link
Member

@KANAjetzt KANAjetzt commented Jun 30, 2023

Patch v6.0.2

This patch addresses an issues related to the new user profiles introduced in v6.0.0. It also includes an update for the manifest validation.

Bug fix for ModLoaderUserProfile

Manifest Validation

🚨 Breaking Changes

  • Technically, it may break mods that have the same mod_id listed in both optional_dependencies and dependencies or load_before and incompatibilities. However, since the optional_dependencies and load_before feature was introduced in v6.0.0, it is highly unlikely that such conflicts exist.

Refactored `_update_mod_list()` by adding the missing `.keys()` call, removing the outdated check for uninstalled mods, and implemented an if statement in `_setup_mods()` within *mod_loader.gd* to prevent initializing `mod_data` twice, which resolves the issue of the missing `zip_data`.

closes #306
@KANAjetzt KANAjetzt added this to the v6.0.2 milestone Jun 30, 2023
@KANAjetzt KANAjetzt requested review from ithinkandicode, Qubus0, otDan and a team June 30, 2023 06:09
@KANAjetzt KANAjetzt self-assigned this Jun 30, 2023
@KANAjetzt KANAjetzt changed the title fix: 🐛 mod_data init and uninstall detection (#307) v6.0.2 Jun 30, 2023
Copy link
Collaborator

@ithinkandicode ithinkandicode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget the version bump in mod_loader_store!

const MODLOADER_VERSION = "6.0.1"

Added validation to check for the same mod_ids in `optional_dependencies` and `dependencies`

Technically, it may break mods that have the same `mod_id` listed in both the `optional_dependencies` and `dependencies` sections. However, since the `optional_dependencies` feature was introduced in v6.0.0, it is highly unlikely that such conflicts exist.
Added validation to check for the same mod_ids in `load_before` and `incompatibilities`

Technically, it may break mods that have the same `mod_id` listed in both the `load_before` and `incompatibilities` sections. However, since the `load_before` feature was introduced in v6.0.0, it is highly unlikely that such conflicts exist.
@KANAjetzt KANAjetzt requested review from ithinkandicode and a team June 30, 2023 23:40
@KANAjetzt KANAjetzt merged commit 26bcc8d into main Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants