refactor: ♻️ unique ids optional_dependencies - dependencies
#308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added validation to check for the same mod_ids in `optional_dependencies` and `dependencies` Technically, it may break mods that have the same `mod_id` listed in both the `optional_dependencies` and `dependencies` sections. However, since the `optional_dependencies` feature was introduced in v6.0.0, it is highly unlikely that such conflicts exist.
KANAjetzt
added
validation
Merged
Qubus0
approved these changes
Jun 30, 2023
KANAjetzt
deleted the
refactor_ceck_distinct_mod_ids_for_optional_dependencies_and_dependencies
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added validation to check for the same mod_ids in
optional_dependenciesanddependenciesBreaking Changes:
Technically, it may break mods that have the same
mod_idlisted in both theoptional_dependenciesanddependenciessections. However, since theoptional_dependenciesfeature was introduced in v6.0.0, it is highly unlikely that such conflicts exist.