Skip to content

Improve registry mod #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
obilodeau merged 2 commits into from
Sep 27, 2017
Merged

Improve registry mod #84

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2e8033
Improve registry mod
snakems Sep 25, 2017
e9b4177
Improve code
snakems Sep 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion malboxes/malboxes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,6 +501,11 @@ def registry(profile_name, reg_mod, fd):
Adds a registry key modification to a profile with PowerShell commands.
"""
if reg_mod["modtype"] == "add":
# Creates registry path if it doesn't exist
reg_key_line = 'if ( -not (Test-Path "{0}") ){{New-Item "{0}" -Force}}\r\n' \
.format(reg_mod["key"])
fd.write(reg_key_line)

command = "New-ItemProperty"
line = '{} -Path "{}" -Name "{}" -Value "{}" -PropertyType "{}"\r\n' \
.format(command, reg_mod["key"], reg_mod["name"], reg_mod["value"],
Expand Down Expand Up @@ -560,7 +565,7 @@ def document(profile_name, modtype, docpath, fd):
line = '{0} -Path "{1}"\r\n'.format(command, docpath)
print("Removing file: {}".format(docpath))
else:
print("Directory modification type invalid.")
print("Document modification type invalid.")
print("Valid ones are: add, delete.")

fd.write(line)
Expand Down