Skip to content

Conversation

@snakems
Copy link
Contributor

@snakems snakems commented Sep 25, 2017

Improve registry mod
Fix print

Improve registry mod
Fix print
@obilodeau
Copy link
Contributor

Thanks @snakems!

@Svieg do you see any disadvantage of creating missing registry paths like this patch does?

Adds a registry key modification to a profile with PowerShell commands.
"""
if reg_mod["modtype"] == "add":
reg_key_line = 'if ( -not (Test-Path "{0}") ){{New-Item "{0}" -Force}}\r\n' \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment here like:

# Creates registry path if it doesn't exist

Thanks!

@obilodeau obilodeau merged commit 029d76f into GoSecure:master Sep 27, 2017
@snakems snakems deleted the registry_mod_fix branch September 28, 2017 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants