Feature/add left button optional #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
February 22, 2018 12:24
…essageViewController into feature/add-left-button
|
This is awesome! Will set aside some time to review! Sent with GitHawk |
SD10
reviewed
Feb 23, 2018
|
|
||
| private func setRight(buttonTitle: String, for state: UIControlState) { | ||
| rightButton.setTitle(buttonTitle, for: state) | ||
| } |
There was a problem hiding this comment.
Nit: These look like unnecessary wrappers for these methods. It would be better to just call them directly
|
Can we get this pull request merged? Would be really nice with support for a left button 😃 |
This was referenced Mar 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By setting the showLeftButton flag you can enable or disable the left accessory button.