Inconsistent text view font

[AndrewBarba]

The latest release, 0.2.0, is causing the font to change in the text view as I type. Also introducing the left button has caused some really strange layout issues. For example, if I set showsLeftButton to false, the insets are rendered completely off center.

[rnystrom]

Blame #33 cc @lenkaiser

[rnystrom]

@AndrewBarba does it repro in the example if you just disable the left button?

[rnystrom]

@AndrewBarba I can't seem to repro this in the example. Can you give some more details? Are you also setting the left button inset?

[AndrewBarba]

Simply updating the library (no other code changes), went from this:

To this:

And then typing notice how the first letter is a completely different font than the rest, and the text view just became a larger size (probably due to font change):

Adding one line of code to disable the left button (messageView.showLeftButton = false) produced this:

[AndrewBarba]

Okay this stuff for text view frame based on insets is all just completely wrong:

        // adjust by bottom offset so content is flush w/ text view
        let leftButtonFrame = CGRect(
            x: insetBounds.minX,
            y: (insetBounds.minY + textViewHeight) - leftButtonSize.height + leftButton.bottomHeightOffset,
            width: leftButtonSize.width,
            height: leftButtonSize.height
        )
        leftButton.frame = (showLeftButton) ? leftButtonFrame : .zero
        
        let textViewFrame = CGRect(
            x: ((showLeftButton) ? leftButtonFrame.maxX : 0) + leftButtonInset,
            y: insetBounds.minY,
            width: insetBounds.width - ((showLeftButton) ? leftButtonSize.width : 0) - leftButtonInset - rightButtonSize.width,
            height: textViewHeight
        )
        textView.frame = textViewFrame

        // adjust by bottom offset so content is flush w/ text view
        let rightButtonFrame = CGRect(
            x: textViewFrame.maxX + leftButtonInset,
            y: textViewFrame.maxY - rightButtonSize.height + rightButton.bottomHeightOffset,
            width: rightButtonSize.width,
            height: rightButtonSize.height
        )
        rightButton.frame = rightButtonFrame

[AndrewBarba]

Why not just use a stack view for this?

[rnystrom]

Ya fixing the inset stuff now. It's wrong.

Why not just use a stack view for this?

Not going to involve AL layout hooks in this, I want fine control over what layout happens and when so that I can control when the text view resizes.

[AndrewBarba]

Yup makes sense. While you're fixing that, any chance you can decouple the font property from setting the font for text view and all buttons? I'd prefer to set the fonts individually

[rnystrom]

Agree, stripping that part

[AndrewBarba]

@rnystrom I'm still seeing really strange layout and font issues on 0.2.1.

On load:

After typing:

And here's my config:

        // Setup the button using text or an icon
        messageView.showLeftButton = false

        // Right button
        messageView.setButton(title: "Send".uppercased(), for: .normal, position: .right)
        messageView.setButton(font: UIFont(barstool: .branding, size: 14), position: .right)
        messageView.addButton(target: self, action: #selector(handleSendButtonTapped), position: .right)
        messageView.rightButtonTint = .barstoolBrightBlue

        // Change the appearance of the text view and its content
        messageView.font = UIFont(barstool: .branding, size: 14)
        messageView.textView.font = UIFont(barstool: .regular, size: 14)
        messageView.textView.placeholderText = "Type comment..."
        messageView.textView.placeholderTextColor = .lightGray
        messageView.textView.tintColor = .barstoolBrightBlue
        messageView.applyBorder(.top, color: .separator, size: 0.5)
        messageView.inset = UIEdgeInsets(top: 20, left: 16, bottom: 20, right: 16)

        // Capsule view
        let containerView = UIView()
        containerView.backgroundColor = UIColor(red: 0.945, green: 0.945, blue: 0.945, alpha: 1)
        containerView.borderColor = .separator
        containerView.borderWidth = 1
        containerView.cornerRadius = 3

        messageView.insertSubview(containerView, at: 0)
        containerView.snp.makeConstraints {
            $0.top.equalToSuperview().inset(8)
            $0.leading.equalToSuperview().inset(8)
            $0.trailing.equalToSuperview().inset(8)
            if #available(iOS 11, *) {
                $0.bottom.equalTo(messageView.safeAreaLayoutGuide.snp.bottom).inset(8)
            } else {
                $0.bottom.equalToSuperview().inset(8)
            }
        }

[rnystrom]

I’ll try to repro the font issue today and send another patch, I actually didn’t see this issue so didn’t make any change for it.

_{Sent with GitHawk}