-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Reduction: SAT to Circuit SAT #89
Conversation
Please fix the tests @SciCodePhy |
Resolved: Previously, the circuit SAT might return some solutions in which the total CNF (the total "variable") might be false. In the updated extract solution function, we screen out these unuseful solutions. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
==========================================
+ Coverage 94.04% 94.46% +0.41%
==========================================
Files 33 34 +1
Lines 1277 1318 +41
==========================================
+ Hits 1201 1245 +44
+ Misses 76 73 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
No description provided.