Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Reduction: SAT to Circuit SAT #89

Merged
merged 8 commits into from
Sep 29, 2024
Merged

New Reduction: SAT to Circuit SAT #89

merged 8 commits into from
Sep 29, 2024

Conversation

SciCodePhy
Copy link
Collaborator

No description provided.

@SciCodePhy SciCodePhy marked this pull request as ready for review September 19, 2024 13:03
@GiggleLiu
Copy link
Owner

Please fix the tests @SciCodePhy

@SciCodePhy
Copy link
Collaborator Author

SciCodePhy commented Sep 29, 2024

Please fix the tests @SciCodePhy

Resolved: Previously, the circuit SAT might return some solutions in which the total CNF (the total "variable") might be false. In the updated extract solution function, we screen out these unuseful solutions.

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.46%. Comparing base (982a86d) to head (e25dd4c).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
src/rules/circuit_sat.jl 95.23% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
+ Coverage   94.04%   94.46%   +0.41%     
==========================================
  Files          33       34       +1     
  Lines        1277     1318      +41     
==========================================
+ Hits         1201     1245      +44     
+ Misses         76       73       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@GiggleLiu GiggleLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@GiggleLiu GiggleLiu merged commit 33508bf into main Sep 29, 2024
5 checks passed
@SciCodePhy SciCodePhy linked an issue Sep 29, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce 3-SAT to CircuitSAT
2 participants