Skip to content

Fixed visibility of tabbar when reactions are shown #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 10, 2025

Conversation

martinmitrevski
Copy link
Contributor

🔗 Issue Link

Resolves #748.

🎯 Goal

When a tab bar is shown in a channel view, and the reactions popup is shown, the tab bar covers the popup.

🛠 Implementation

Using the toolbar API to hide the tab bar in this case.

🧪 Testing

Describe the steps how this change can be tested (or why it can't be tested).

🎨 Changes

Add relevant screenshots or videos showcasing the changes.

☑️ Checklist

  • I have signed the Stream CLA (required)
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Affected documentation updated (docusaurus, tutorial, CMS (task created)

@martinmitrevski martinmitrevski requested a review from a team as a code owner February 10, 2025 13:32
@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Feb 10, 2025

SDK Size

title develop branch diff status
StreamChatSwiftUI 7.58 MB 7.58 MB +2 KB 🟢

Copy link
Member

@nuno-vieira nuno-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅ Just added a small nit in the changelog

Co-authored-by: Nuno Vieira <nuno.fcvieira93@gmail.com>
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
71.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@martinmitrevski martinmitrevski enabled auto-merge (squash) February 10, 2025 15:43
@martinmitrevski martinmitrevski merged commit 9854b64 into develop Feb 10, 2025
11 of 12 checks passed
@martinmitrevski martinmitrevski deleted the tab-bar-reactions branch February 10, 2025 15:44
@Stream-SDK-Bot Stream-SDK-Bot mentioned this pull request Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The position of ReactionsOverlayView is incorrect when the tab bar is configured to appear
3 participants