Skip to content

The position of ReactionsOverlayView is incorrect when the tab bar is configured to appear #748

Closed
@sheep-q

Description

@sheep-q

What did you do?

  1. Configure the tab bar to appear when moving to ChatChannelListView:
  • Set handleTabBarVisibility = false in ChatChannelListView
  • Set handleTabBarVisibility = false in MessageListConfig
  1. Navigate to ChatChannelListView
  2. Long tap on a message to show reactions view
  3. See the overlay reaction appearing

What did you expect to happen?

Expected:
The position of the blurred background, avatar, message container, top and bottom reactions view is correct, like the picture below without the tab bar

image

What happened instead?

Issue:

  • The position of the overlay reaction (includes blurred background, avatar, message container, top and bottom reactions view) is shifted slightly upward. The animation is not smooth either.
    Video:
Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2025-02-10.at.10.19.05.mp4
  • The popup module is also slightly cut off by the navigation bar below (2):
image

GetStream Environment

GetStream Chat version: 4.70.0
GetStream Chat frameworks: StreamChat, StreamChatSwiftUI
iOS version: 17.5, 18.2
Swift version: Swift 5
Xcode version: XCode 16.2
Device: iPhone SE - iOS 17.5, iPhone 15 pro - iOS 17.5, 18.2

Additional context

I see that the snippet code below addresses the issue for iPad, not iPhone. How do you come up with the number 20 and should we add logic for iPhone here?

ref: ReactionsOverlayView.Swift file

private var overlayOffsetY: CGFloat {
        if isIPad && UITabBar.appearance().isHidden == false {
            // When using iPad with TabBar, this hard coded value makes
            // sure that the overlay is in the correct position.
            return 20
        }
        return spacing > 0 ? screenHeight - currentSnapshot.size.height : 0
    }

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions