feat(flutter): Desktop support for stream_chat_flutter
#913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GroovinChip
added
enhancement
GroovinChip
changed the title
stream_chat_flutterstream_chat_flutter
Codecov Report
@@ Coverage Diff @@
## desktop_beta #913 +/- ##
================================================
- Coverage 67.87% 67.53% -0.34%
================================================
Files 228 299 +71
Lines 23561 25004 +1443
================================================
+ Hits 15992 16887 +895
- Misses 7569 8117 +548
Continue to review full report at Codecov.
|
Also removes deprecated _showErrorDialog() function
# Conflicts: # packages/stream_chat_flutter/lib/src/full_screen_media.dart
This was
linked to
issues
Feb 28, 2022
Closed
Closed
* Make buttons more visible * Spacing from the sides of the screen
1 task
3 tasks
commit 4b880ecb6d4dcbf315a7d41d863174817a9c530a
Author: Reuben Turner <groovinchip@gmail.com>
Date: Thu Jun 9 12:25:21 2022 -0400
fix(flutter): fixes for desktop reactions
* Fix reactions for reverse messages
* Ensure reactions near the edges of MessageListView show properly
commit f511513
Author: Salvatore Giordano <salvatoregiordanoo@gmail.com>
Date: Thu Jun 9 16:43:03 2022 +0200
fix(ui): fix DesktopReactionBuilder and Portal
commit c488564
Merge: 2b710a2 72b34c2
Author: Reuben Turner <groovinchip@gmail.com>
Date: Wed Jun 8 14:12:44 2022 -0400
Merge branch 'desk_web_dev' into desktop_reactions
commit 2b710a2
Author: Reuben Turner <groovinchip@gmail.com>
Date: Mon Jun 6 12:19:12 2022 -0400
chore(flutter): add debug props
commit e24dabc
Author: Reuben Turner <groovinchip@gmail.com>
Date: Mon Jun 6 12:00:03 2022 -0400
feat(flutter): first pass at desktop reactions popup on mouse hover
with debug props
* Fix bottom row being rendered above reaction buttons * Fix padding issues related to avatars
# Conflicts: # packages/stream_chat_flutter/lib/src/message_widget.dart # packages/stream_chat_flutter/lib/src/video/video_thumbnail_image.dart # packages/stream_chat_localizations/lib/src/stream_chat_localizations_de.dart
Also removed commented code
* Show "You" if userId matches the reaction username (per design) * Ensure long names don't throw off alignment
This was
unlinked from
issues
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLA
This PR contains all of my work on
stream_chat_flutterto support desktop platforms. The work that needs to be done is as follows:MessageInputKeyboard Shortcuts & Improvements #923PlatformWidgetBuilderto its own packageMessageWidgets on desktop #960ChannelListViewitems for desktop & web #1018New tasks as of 5/25/22
userAvatarBuildertoMessageWidgetContentusernameBuildertoMessageWidgetContentQuotedMessageWidgetwhen replyingStreamMessageListViewnot scrolling to the bottom when new messages are sentQuotedMessageWidgetwhen replyingAdditionally, this PR contains massive refactoring to existing widgets that are unrelated to the above issues, specifically:
Widget build()methodsWidget build()helper methodsNavigator.whateversyntax toNavigator.of(context).whateversyntaxvoid asyncfunctions asFuture<void> asyncthat have not already been done soTo check if any of the above issues are compatible with Flutter Web, please view the issue labels.