Skip to content

feat(persistence): allow experimental indexedDB on web #1189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

geweald
Copy link
Contributor

@geweald geweald commented Jun 2, 2022

Submit a pull request

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

Fix for #1017
Resolves conflicts of #1016

@codecov
Copy link

codecov bot commented Jun 2, 2022

Codecov Report

Merging #1189 (72dbca0) into develop (7732953) will decrease coverage by 0.01%.
The diff coverage is 6.66%.

@@             Coverage Diff             @@
##           develop    #1189      +/-   ##
===========================================
- Coverage    67.89%   67.87%   -0.02%     
===========================================
  Files          228      228              
  Lines        23560    23562       +2     
===========================================
- Hits         15995    15992       -3     
- Misses        7565     7570       +5     
Impacted Files Coverage Δ
...stence/lib/src/stream_chat_persistence_client.dart 92.47% <0.00%> (-0.50%) ⬇️
...src/v4/message_input/stream_attachment_picker.dart 31.91% <9.09%> (-1.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb2d008...72dbca0. Read the comment docs.

@imtoori
Copy link
Contributor

imtoori commented Jun 9, 2022

Thanks a lot for the pr!

Looks good to me, but it's breaking as far as I understood

I'd keep this open and wait for the work on web to start
we're currently finishing the work on desktop here and then we're gonna move to web

@geweald
Copy link
Contributor Author

geweald commented Jun 10, 2022

Hi @imtoori why do you think it's breaking? The flag is optional and without it the default behavior remains the same

@geweald geweald force-pushed the feat/indexed-db-web branch from a82f763 to 72dbca0 Compare June 20, 2022 10:02
Copy link
Member

@xsahil03x xsahil03x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xsahil03x xsahil03x merged commit f6f0d6e into GetStream:develop Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants