[Fixes #13113] Fixing multiple Keyerror logs when DEBUG=False

geonode/services/serviceprocessors/wms.py

@@ -131,7 +131,7 @@ def create_geonode_service(self, owner, parent=None):
         """
         service = None
         try:
-            cleaned_url, service, version, request = WmsServiceHandler.get_cleaned_url_params(self.url)
+            cleaned_url, service_name, version, request = WmsServiceHandler.get_cleaned_url_params(self.url)
             with transaction.atomic():
                 service = models.Service.objects.create(
                     uuid=str(uuid4()),

geonode/services/tests.py

@@ -824,8 +824,9 @@ def test_add_duplicate_remote_service_url(self):
             # Try adding the same URL again
             form = forms.CreateServiceForm(form_data)
             self.assertEqual(Service.objects.count(), 1)
-            with self.assertRaises(KeyError):
-                self.client.post(reverse("register_service"), data=form_data)
+            response = self.client.post(reverse("register_service"), data=form_data)
+            # The service is None since there is already a created service from the first call
+            self.assertEqual(response.status_code, 404)
             self.assertEqual(Service.objects.count(), 1)
 
 

geonode/urls.py

@@ -221,3 +221,5 @@
 urlpatterns += [
     re_path(r"^metadata_update_redirect$", views.metadata_update_redirect, name="metadata_update_redirect"),
 ]
+
+handler500 = "geonode.views.err500"

geonode/views.py

@@ -20,6 +20,7 @@
 from geonode.client.hooks import hookset
 import json
 
+from django.shortcuts import render
 from django import forms
 from django.apps import apps
 from django.db.models import Q
@@ -99,6 +100,10 @@
         return TemplateResponse(request, "401.html", {}, status=401).render()
 
 
+def err500(request):
+    return render(request, "500.html", status=500)
+
+
 def ident_json(request):
     site_url = settings.SITEURL.rstrip("/") if settings.SITEURL.startswith("http") else settings.SITEURL
     json_data = {}