Skip to content

Conversation

@Gpetrak
Copy link
Member

@Gpetrak Gpetrak commented Apr 30, 2025

This PR was created according to this issue: #13113

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@Gpetrak Gpetrak requested a review from giohappy April 30, 2025 07:24
@Gpetrak Gpetrak self-assigned this Apr 30, 2025
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Apr 30, 2025
@Gpetrak Gpetrak marked this pull request as ready for review May 2, 2025 13:15
@codecov
Copy link

codecov bot commented May 2, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.82%. Comparing base (67096b1) to head (7f784ab).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #13141      +/-   ##
==========================================
- Coverage   67.83%   67.82%   -0.01%     
==========================================
  Files         980      980              
  Lines       57603    57607       +4     
  Branches     6649     6648       -1     
==========================================
  Hits        39074    39074              
- Misses      16955    16960       +5     
+ Partials     1574     1573       -1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Gpetrak Gpetrak linked an issue May 2, 2025 that may be closed by this pull request
@giohappy giohappy merged commit 9506849 into master May 2, 2025
17 checks passed
@giohappy giohappy deleted the ISSUE_13113 branch May 2, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.4.x cla-signed CLA Bot: community license agreement signed investigation master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate verbose log outputs

3 participants