Bring back old Copy / Paste system #1771

NekoGryphou · 2020-09-18T13:01:10Z

The new copy / paste system is not ergonomic at all .
I'd much rather paste text in "letter by letter input" mode when I press ctrl + v rather than having to do alt + shit + v.
And when I do alt + v, it pastes the text from the clipboard which is not necessarily the one I want to put.

If i rebind the mod key to ctrl instead of alt, it's a real messe with copy / paste too.

Can you add an option to get back to the old behavior; I use this application all day long and it's getting complicated now and I'm losing time due to errors related to copy / paste.

Thanks you

The text was updated successfully, but these errors were encountered:

rom1v · 2020-09-18T13:08:10Z

And when I do alt + v, it pastes the text from the clipboard which is not necessarily the one I want to put.

The content pasted by with Alt+v should be the same as the one pasted with Alt+Shift+v (and the same as the one pasted with Ctrl+v).

If this is not the case, then probably device.setClipboardText(text) does not work on your device ROM, see #1750 (possibly because your device is rooted #1678?).

Which Android version, which Android ROM? Could you try with another device?

NekoGryphou · 2020-09-18T13:33:44Z

I've got an Samsung Galaxy S9+ and Android 10 samsung rom.
Not rooted.

But, why did you change ctrl + v to alt + v ?

rom1v · 2020-09-18T13:36:31Z

But, why did you change ctrl + v to alt + v ?

To forward the Ctrl key to the device.

See v1.15 highlights and #1598 for more details.
The new expected behavior is as described in the README: https://github.com/Genymobile/scrcpy#copy-paste

NekoGryphou · 2020-09-18T13:38:38Z

When i hit ctrl + v or alt + v, it sync the computer clipboard to the device OR if there is something in the smartphone's clipboard, it pastes it and synchronizes after pasting the old text...

rom1v · 2020-09-18T13:39:31Z

Oh, wait, do you use v1.16?

Because there was a bug in v1.15: #1658

NekoGryphou · 2020-09-18T13:44:29Z

Yes, i use the v1.16 version

rom1v · 2020-09-18T13:46:47Z

When i hit ctrl + v or alt + v, it sync the computer clipboard to the device OR if there is something in the smartphone's clipboard, it pastes it and synchronizes after pasting the old text...

OK, so IIUC, the second time you press Ctrl+v, it correctly pastes the expected content, right?

NekoGryphou · 2020-09-18T14:09:49Z

Here's a video example : https://streamable.com/r1k9nc

rom1v · 2020-09-18T14:22:26Z

OK, thank you for the video. 👍

So it seems that device.setClipboardText(text) does something on the device (we see the content in the clipboard on your device), but is not pasted, neither with Ctrl+v nor Alt+v (unless the content is initially copied from the device).

You could also test adb shell input keyevent PASTE manually to paste, I guess you will have the same problem.

I think it's the very same issue as #1750.

I would say this is a device bug: once the content is in the clipboard (as shown above the device keyboard), injecting PASTE or pressing Ctrl+v should paste it.

Could you capture the logcat content when you press Ctrl+v in the scrcpy window for the first time (with a new random content, different from the previous one), please?

Start scrcpy and from a new terminal, execute:

adb logcat -c  # clear
# copy some text and press Ctrl+v in the scrcpy window
adb logcat -d > logcat.txt

NekoGryphou · 2020-09-18T14:32:38Z

When i do adb shell input keyevent PASTE, it paste the older clipboard element, not the new one.
Github upload it's a bit buggy today, so here,s a link to the logcat.txt content : https://hastebin.com/umayuhecax.txt

NekoGryphou · 2020-09-18T14:36:46Z

Maybe it's a bug with Google Keyboard (the content is well copied in the clipboard of GBoard), but before the v1.16, things work perfectly with the "letter by letter paste" (alt + shift + v now)

rom1v · 2020-09-18T14:40:22Z

When i do adb shell input keyevent PASTE, it paste the older clipboard element, not the new one.

OK, so it suggests a device system bug (or intended restriction).

The method scrcpy uses to set the clipboard is "public" (usable by any app): ClipboardManager.setPrimaryClip().

I'm interested to know if you set the text from some app using this API and try to paste with adb shell input keyevent PASTE. This would allow to reproduce the problem without scrcpy.

There are probably some simple "clipboard manager" apps which allow to explicitly set some text to the clipboard using this.

NekoGryphou · 2020-09-18T14:44:40Z

I test with https://play.google.com/store/apps/details?id=devdnua.clipboard and it work when i paste the clipboard content
I don't really have the time to create an app for testing this, sorry.
However if you do one, i can test for you

rom1v · 2020-09-18T14:53:47Z

I test with https://play.google.com/store/apps/details?id=devdnua.clipboard and it work when i paste the clipboard content

😕

rom1v · 2020-09-18T16:28:52Z

I wrote a minimal scrcpy-like sample application to get and set the clipboard.

Download clipboard.dex
SHA256: 3c7205c58c26f4ed42feda56ce3c312b13b5ff11c980817bccdc5882f629fed2

Then push it to the device:

adb push clipboard.dex /data/local/tmp/

Then, you can execute:

# get the current clipboard text
adb shell CLASSPATH=/data/local/tmp/clipboard.dex app_process / Clipboard get
# set the clipboard text
adb shell CLASSPATH=/data/local/tmp/clipboard.dex app_process / Clipboard set abcdefgh

Please try to set the clipboard, check the result by reading the current content.
Then focus some text field on Android, and execute adb shell input keyevent PASTE to inject it.

What is the behavior?

source code

import android.content.ClipData;
import android.os.Build;
import android.os.IBinder;
import android.os.IInterface;

import java.lang.reflect.InvocationTargetException;
import java.lang.reflect.Method;

public class Clipboard {

    private static final String PACKAGE_NAME = "com.android.shell";
    private static final int USER_ID = 0;

    private static Method getPrimaryClipMethod;
    private static Method setPrimaryClipMethod;
    private static boolean legacySet;

    private static IInterface getService(String service, String type) {
        try {
            Method getServiceMethod = Class.forName("android.os.ServiceManager").getDeclaredMethod("getService", String.class);
            IBinder binder = (IBinder) getServiceMethod.invoke(null, service);
            Method asInterfaceMethod = Class.forName(type + "$Stub").getMethod("asInterface", IBinder.class);
            return (IInterface) asInterfaceMethod.invoke(null, binder);
        } catch (Exception e) {
            throw new AssertionError(e);
        }
    }

    private static IInterface getClipboardManager() {
        return getService("clipboard", "android.content.IClipboard");
    }

    private static Method getGetPrimaryClipMethod(IInterface manager) throws NoSuchMethodException {
        if (getPrimaryClipMethod == null) {
            if (Build.VERSION.SDK_INT < Build.VERSION_CODES.Q) {
                getPrimaryClipMethod = manager.getClass().getMethod("getPrimaryClip", String.class);
            } else {
                getPrimaryClipMethod = manager.getClass().getMethod("getPrimaryClip", String.class, int.class);
            }
        }
        return getPrimaryClipMethod;
    }

    private static Method getSetPrimaryClipMethod(IInterface manager) throws NoSuchMethodException {
        if (setPrimaryClipMethod == null) {
            if (Build.VERSION.SDK_INT < Build.VERSION_CODES.Q) {
                setPrimaryClipMethod = manager.getClass().getMethod("setPrimaryClip", ClipData.class, String.class);
            } else {
                setPrimaryClipMethod = manager.getClass().getMethod("setPrimaryClip", ClipData.class, String.class, int.class);
            }
        }
        return setPrimaryClipMethod;
    }

    private static ClipData getPrimaryClip(Method method, IInterface manager) throws InvocationTargetException, IllegalAccessException {
        if (Build.VERSION.SDK_INT < Build.VERSION_CODES.Q) {
            return (ClipData) method.invoke(manager, PACKAGE_NAME);
        }
        return (ClipData) method.invoke(manager, PACKAGE_NAME, USER_ID);
    }

    private static void setPrimaryClip(Method method, IInterface manager, ClipData clipData)
            throws InvocationTargetException, IllegalAccessException {
        if (Build.VERSION.SDK_INT < Build.VERSION_CODES.Q) {
            method.invoke(manager, clipData, PACKAGE_NAME);
        } else {
            method.invoke(manager, clipData, PACKAGE_NAME, USER_ID);
        }
    }

    public static CharSequence getText(IInterface manager) {
        try {
            Method method = getGetPrimaryClipMethod(manager);
            ClipData clipData = getPrimaryClip(method, manager);
            if (clipData == null || clipData.getItemCount() == 0) {
                return null;
            }
            return clipData.getItemAt(0).getText();
        } catch (InvocationTargetException | IllegalAccessException | NoSuchMethodException e) {
            System.err.println("Could not invoke method");
            return null;
        }
    }

    public static boolean setText(IInterface manager, CharSequence text) {
        try {
            Method method = getSetPrimaryClipMethod(manager);
            ClipData clipData = ClipData.newPlainText(null, text);
            setPrimaryClip(method, manager, clipData);
            return true;
        } catch (InvocationTargetException | IllegalAccessException | NoSuchMethodException e) {
            System.err.println("Could not invoke method");
            return false;
        }
    }

    private static void syntax() {
        System.err.println("Syntax: adb shell CLASSPATH=/data/local/tmp/clipboard app_process / Clipboard [options]");
        System.err.println("options:");
        System.err.println("    get");
        System.err.println("    set 'SOME TEXT'");
        System.exit(1);
    }

    private static void error() {
        syntax();
        System.exit(1);
    }

    private static CharSequence getClipboard() {
        IInterface manager = getClipboardManager();
        return getText(manager);
    }

    public static boolean setClipboard(CharSequence text) {
        IInterface manager = getClipboardManager();
        return setText(manager, text);
    }

    public static void main(String... args) throws Exception {
        if (args.length == 0) {
            error();
        }
        if ("get".equals(args[0])) {
            if (args.length != 1) {
                error();
            }
            System.out.println("get: " + getClipboard());
        } else if ("set".equals(args[0])) {
            if (args.length != 2) {
                error();
            }
            String text = args[1];
            if (setClipboard(text)) {
                System.out.println("set: " + text);
            } else {
                System.err.println("set error");
            }
        } else {
            error();
        }
    }
}

Compile with:

javac -source 1.7 -target 1.7 Clipboard.java -cp "$ANDROID_HOME"/platforms/android-30/android.jar
~/android/sdk/build-tools/30.0.0/dx --dex --output clipboard.dex Clipboard.class

rom1v · 2020-09-20T12:35:18Z

Did you have some time to test?

NekoGryphou · 2020-09-21T07:11:46Z

Sorry, i've been a bit busy this week-end.
I just tested your application and the clipboard doesn't work.

CMD :

> adb push clipboarD.dex /data/local/tmp/
clipboard.dex: 1 file pushed, 0 skipped. 1.1 MB/s (4720 bytes in 0.004s)

> adb shell CLASSPATH=/data/local/tmp/clipboard.dex app_process / Clipboard get
get: 923756

> adb shell CLASSPATH=/data/local/tmp/clipboard.dex app_process / Clipboard set abcdefgh
set: abcdefgh

> adb shell CLASSPATH=/data/local/tmp/clipboarD.dex app_process / Clipboard get
get: abcdefgh

> adb shell input keyevent PASTE

Device after PASTE event :

Otherwise, can you tell me how to remove the .dex file from my phone ?

rom1v · 2020-09-21T07:18:15Z

OK, thank you for the test 👍

Otherwise, can you tell me how to remove the .dex file from my phone ?

adb shell rm /data/local/tmp/clipboard.dex

NekoGryphou · 2020-09-21T07:19:20Z

adb shell rm /data/local/tmp/clipboard.dex

Thanks 👍

NekoGryphou · 2020-09-30T11:49:35Z

Any news about a potential patch? :3

rom1v · 2020-09-30T12:12:35Z

No, the test confirms that your device does not behave as expected. I don't have a solution for this. 😞

NekoGryphou · 2020-10-01T08:05:59Z

oh :c

gmiwoj · 2020-10-02T16:17:47Z

seconded.
i'm still on 1.14 because of this. copy pasta works perfectly on 1.14 and is pretty much unusable for me on 1.16

pls bring it back or at least make it an option

rom1v · 2020-10-02T16:34:02Z

Could you confirm that the issue only occurs with paste, but that copy works correctly: if you select a text then press Ctrl+c on the device (in the scrcpy window), could you paste it on the computer?

hoanngothanh · 2020-10-05T04:04:51Z

Could you confirm that the issue only occurs with paste, but that copy works correctly: if you select a text then press Ctrl+c on the device (in the scrcpy window), could you paste it on the computer?

Hi rom1v
I can confirm when I copy from scrcpy window I can paste it to PC. But copy from pc then pastes to scrcpy have issue. I'm using the latest version of scrcpy

rom1v · 2020-10-06T19:35:17Z

I've just implemented an option on a separate branch (legacy_paste):

scrcpy --legacy-paste

Could you please test it?

For windows users, take both scrcpy.exe and scrcpy-server, and replace them in your scrcpy v1.16 release.

For other platforms, take scrcpy-server and build only the client.

scrcpy.exe
SHA256: 38b541d7cef76d424a72316faae02a9e8f78c021cb5d0d60721d701c43bafd13
scrcpy-server
SHA256: 467beb2762d822766ccf76fc7bd47cd3950293d21eab041c62b0b5bd279039c1

Some devices do not behave as expected when setting the device clipboard programmatically. Add an option --legacy-paste to change the behavior of Ctrl+v and MOD+v so that they inject the computer clipboard text as a sequence of key events (the same way as MOD+Shift+v). Fixes #1750 <#1750> Fixes #1771 <#1771>

rom1v · 2020-10-12T08:26:38Z

Could you please test? I'm interested in knowing if it solves your problem.

NekoGryphou · 2020-10-12T14:34:26Z

CTRL + V paste "letter by letter" now

rom1v · 2020-10-12T14:40:43Z

Yes, that's the workaround if the device PASTE does not behave as expected. 👍

Is it a better behavior?

NekoGryphou · 2020-10-12T15:28:37Z

it's better than a buggy thing ^^
Thanks !

atscripter · 2020-10-14T21:13:40Z

@rom1v Tested, working. Thank you.

atscripter · 2020-10-14T22:51:13Z

Can we get one for scrcpy-noconsole.exe too? :)

NekoGryphou · 2020-11-05T15:15:14Z

Any new version planned with this ?

Some devices do not behave as expected when setting the device clipboard programmatically. Add an option --legacy-paste to change the behavior of Ctrl+v and MOD+v so that they inject the computer clipboard text as a sequence of key events (the same way as MOD+Shift+v). Fixes #1750 <#1750> Fixes #1771 <#1771>

rom1v · 2020-11-07T14:22:41Z

--legacy-paste option merged into dev: d5f059c

XeonG · 2021-01-17T18:25:30Z

Also having this problem with pasting not working... I did try the legacy paste argument on the cmd line which works.. but its buggy it just leaves out characters, and doesn't even paste the whole clipboard from there pc.

copy works fine.. just not pasting from the pc, Samsung note9

is there any solution to this.. I'd be fine with legacy paste if it actually pasted all the characters from the clipboard.

scrcpy v1.17 Changes since v1.16: - Fix errors on Android 11 (Genymobile#1468) - Add --encoder option (Genymobile#1810, Genymobile#1827) - Add --forward-all-clicks option (Genymobile#1302, Genymobile#1613) - Add --legacy-paste option (Genymobile#1750, Genymobile#1771) - Workaround screen off/on issue on exit (Genymobile#1670) - Rework console/noconsole versions on Windows (Genymobile#1875, Genymobile#1988) - Terminate server properly without killing it on close (Genymobile#1992) - List available shortcut keys on error (Genymobile#1681) - Upgrade platform-tools to 30.0.5 (adb) in Windows releases - Upgrade SDL to 2.0.14 in Windows releases

scruel · 2024-09-16T13:41:52Z

@rom1v how to set multiple lines with this command? Tried with the following commands (powershell), but all of them won't work:

PS > adb shell CLASSPATH=/data/local/tmp/clipboard.dex app_process / Clipboard set "line1\nline2"
set: line1nline2
PS > adb shell CLASSPATH=/data/local/tmp/clipboard.dex app_process / Clipboard set "line1\\nline2"
set: line1\nline2
PS > adb shell CLASSPATH=/data/local/tmp/clipboard.dex app_process / Clipboard set "line1\\\\nline2"
set: line1\\nline2
PS > adb shell CLASSPATH=/data/local/tmp/clipboard.dex app_process / Clipboard set "line1`nline2"
set: line1
/system/bin/sh: line2: inaccessible or not found

rom1v · 2024-09-16T13:45:58Z

This is not specific to this command, make tests with adb shell echo. There are two levels of shell interpretation:

your local shell (and it does not behave the same way on Linux or Windows)
the Android shell

Something like this should work:

$ adb shell echo "first\\\nsecond"
first
second
$ adb shell echo "first$'\n'second"
first
second

scruel · 2024-09-16T13:48:32Z

This is not specific to this command, make tests with adb shell echo. There are two levels of shell interpretation:
* your local shell (and it does not behave the same way on Linux or Windows)

* the Android shell
Something like this should work:
$ adb shell echo "first\\\nsecond"
first
second
$ adb shell echo "first$'\n'second"
first
second

Thanks!
The following won't work,

PS > adb shell echo "first\\\nsecond"
first
second
PS > adb shell CLASSPATH=/data/local/tmp/clipboard.dex app_process / Clipboard set "first\\\nsecond"
set: first\nsecond

but the following works

adb shell CLASSPATH=/data/local/tmp/clipboard.dex app_process / Clipboard set "first$'\n'second"

rom1v · 2024-09-16T13:51:19Z

PS > adb shell CLASSPATH=/data/local/tmp/clipboard.dex app_process / Clipboard set "first\\\nsecond"
set: first\nsecond

Oh, sure, it works with echo because the \n was interpreted by echo (a third level of parsing).

but the following works

adb shell CLASSPATH=/data/local/tmp/clipboard.dex app_process / Clipboard set "first$'\n'second"

👍 ($'\n' is expanded by the shell before passing the value to the program)

scruel · 2024-09-16T13:56:08Z

PS > adb shell CLASSPATH=/data/local/tmp/clipboard.dex app_process / Clipboard set "first\\\nsecond"
set: first\nsecond
Oh, sure, it works with echo because the \n was interpreted by echo (a third level of parsing).
but the following works
adb shell CLASSPATH=/data/local/tmp/clipboard.dex app_process / Clipboard set "first$'\n'second"
👍 ($'\n is expanded by the shell before passing the value to the program)

I think we may modify the script to generate a new dex file, change:
String text = args[1]
to
String text = args[1].replace('\\n', '\n')

So that:

adb shell CLASSPATH=/data/local/tmp/clipboard.dex app_process / Clipboard set "line1\\nline2"
set: line1\nline2

Should work.

rom1v added the copy_paste label Sep 18, 2020

rom1v added the bug label Sep 18, 2020

This was referenced Oct 14, 2020

copy paste from pc to device is not working #1750

Closed

Copy / Paste Broken on Android 10 #1678

Open

rom1v closed this as completed Nov 7, 2020

rom1v mentioned this issue Dec 21, 2020

Clipboard Ctrl+V to Paste works on Pixel 3a but not Samsung Galaxy S20 FE (both Android 10) with Windows 10. Keyboards not fully synced. #1986

Open

2 tasks

rom1v mentioned this issue Dec 30, 2020

Copy and Paste uses ctrl+c/ctrl+v by default and cannot be changed #1997

Open

rom1v mentioned this issue Feb 9, 2021

How can I copy content from computer and paste it on scrcpy? #2104

Open

scruel mentioned this issue Sep 12, 2024

How to call set_clipboard function via command line? #5282

Closed

Bring back old Copy / Paste system #1771

Bring back old Copy / Paste system #1771

Comments

NekoGryphou commented Sep 18, 2020

rom1v commented Sep 18, 2020 • edited Loading

NekoGryphou commented Sep 18, 2020

rom1v commented Sep 18, 2020

NekoGryphou commented Sep 18, 2020

rom1v commented Sep 18, 2020

NekoGryphou commented Sep 18, 2020

rom1v commented Sep 18, 2020 • edited Loading

NekoGryphou commented Sep 18, 2020

rom1v commented Sep 18, 2020

NekoGryphou commented Sep 18, 2020

NekoGryphou commented Sep 18, 2020 • edited Loading

rom1v commented Sep 18, 2020 • edited Loading

NekoGryphou commented Sep 18, 2020 • edited Loading

rom1v commented Sep 18, 2020 • edited Loading

rom1v commented Sep 18, 2020

rom1v commented Sep 20, 2020

NekoGryphou commented Sep 21, 2020 • edited by rom1v Loading

rom1v commented Sep 21, 2020

NekoGryphou commented Sep 21, 2020 • edited Loading

NekoGryphou commented Sep 30, 2020

rom1v commented Sep 30, 2020

NekoGryphou commented Oct 1, 2020

gmiwoj commented Oct 2, 2020 • edited Loading

rom1v commented Oct 2, 2020 • edited Loading

hoanngothanh commented Oct 5, 2020

rom1v commented Oct 6, 2020

rom1v commented Oct 12, 2020

NekoGryphou commented Oct 12, 2020 • edited Loading

rom1v commented Oct 12, 2020 • edited Loading

NekoGryphou commented Oct 12, 2020

atscripter commented Oct 14, 2020

atscripter commented Oct 14, 2020

NekoGryphou commented Nov 5, 2020

rom1v commented Nov 7, 2020 • edited Loading

XeonG commented Jan 17, 2021

scruel commented Sep 16, 2024 • edited Loading

rom1v commented Sep 16, 2024

scruel commented Sep 16, 2024

rom1v commented Sep 16, 2024 • edited Loading

scruel commented Sep 16, 2024 • edited Loading

rom1v commented Sep 18, 2020 •

edited

Loading

rom1v commented Sep 18, 2020 •

edited

Loading

NekoGryphou commented Sep 18, 2020 •

edited

Loading

rom1v commented Sep 18, 2020 •

edited

Loading

NekoGryphou commented Sep 18, 2020 •

edited

Loading

rom1v commented Sep 18, 2020 •

edited

Loading

NekoGryphou commented Sep 21, 2020 •

edited by rom1v

Loading

NekoGryphou commented Sep 21, 2020 •

edited

Loading

gmiwoj commented Oct 2, 2020 •

edited

Loading

rom1v commented Oct 2, 2020 •

edited

Loading

NekoGryphou commented Oct 12, 2020 •

edited

Loading

rom1v commented Oct 12, 2020 •

edited

Loading

rom1v commented Nov 7, 2020 •

edited

Loading

scruel commented Sep 16, 2024 •

edited

Loading

rom1v commented Sep 16, 2024 •

edited

Loading

scruel commented Sep 16, 2024 •

edited

Loading