Skip to content

Smoke-test binaries by resolving proto bin, not by running --version #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jlouazel merged 1 commit into from
Jun 23, 2026
Merged

Smoke-test binaries by resolving proto bin, not by running --version #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 15 additions & 18 deletions scripts/smoke-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,15 @@
#!/usr/bin/env bash
# Assert every tool pinned in .prototools resolves to a real, runnable binary.
# proto install only downloads and unpacks; it does not follow exe-path, so a
# wrong exe-path produces a dangling symlink that install reports as success.
# `proto bin` resolves exe-path and exits non-zero when the target is missing;
# `proto run -- --version` then proves the binary actually executes.
#
# The tool list comes from the [plugins] table in .prototools (the repo's
# single source of truth), read with the pinned taplo so adding a plugin needs
# no edit here.
# Assert every tool pinned in .prototools resolves to a runnable binary. proto
# install unpacks but does not follow exe-path, so a wrong exe-path leaves a
# dangling target that install still reports as success; proto bin catches it.
set -euo pipefail

cd "$(dirname "$0")/.."

# jq output is CRLF-terminated when taplo runs under Git Bash on Windows; tr
# strips the carriage returns so tool names don't carry a trailing \r.
# Without this proto emits NDJSON in an AI-agent environment, wrapping bin paths.
export PROTO_REPORTER=text

# tr strips the \r taplo's jq output carries under Git Bash on Windows.
tools="$(proto run taplo -- get -f .prototools -o json 'plugins' | jq -r 'keys[]' | tr -d '\r')"

if [ -z "$tools" ]; then
Expand All @@ -23,14 +19,15 @@ fi

failed=0
for tool in $tools; do
if ! proto bin "$tool" >/dev/null 2>&1; then
echo "FAIL $tool: proto could not resolve an executable (check exe-path)"
failed=1
elif ! proto run "$tool" -- --version >/dev/null 2>&1; then
echo "FAIL $tool: resolved but did not run (--version exited non-zero)"
failed=1
else
# || true: proto bin exits non-zero when exe-path is unresolvable.
bin="$(proto bin "$tool" 2>/dev/null | tr -d '\r')" || true
# -f rejects a directory (exe-path pointing into a nested archive); -x rejects
# a non-executable. Both follow symlinks, so proto's shims pass.
if [ -n "$bin" ] && [ -f "$bin" ] && [ -x "$bin" ]; then
echo "ok $tool"
else
echo "FAIL $tool: no runnable executable (check exe-path)"
failed=1
fi
done

Expand Down