Smoke-test binaries by resolving proto bin, not by running --version#9
Merged
Merged
Conversation
- Drop the --version probe; not every tool answers --version (kubeconform uses -v, cloud-provider-kind is a daemon), so it produced false failures - Resolve proto bin and assert the path is an executable file (-f -x), catching the dangling exe-path bug without per-tool special-casing - Force PROTO_REPORTER=text so proto bin emits a bare path in agent environments - Guard the command substitution with || true so set -e does not abort the loop on the first unresolvable tool Signed-off-by: Jean-Baptiste Louazel <jb.louazel@genesis-ai.company>
pylaligand
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The smoke-test ran
proto run <tool> -- --versionon every pinned tool, assuming all tools answer--version. They don't:kubeconformuses-v, andcloud-provider-kindis a daemon with no version flag. PR #8 (which adds both) fails CI on all platforms because of this, even though the binaries install and resolve correctly.Summary
exe-paththat resolves to a directory or a non-executable, covering the nested-archive misconfiguration class, not just a missing target.set -ebug that aborted the loop on the first unresolvable tool (masking every later failure) is fixed, so CI now reports all failures in one run.I verified the new probe against PR #8's two tools locally: both pass. Once this lands, PR #8 goes green on rebase.