Conversation
Bmichotte conflict
|
I also corrected some tests which failed in localized iDevice |
|
Some of those corrected tests were included in my PR #13 that's already been merged. Looks like you need a rebase here before we can merge :) |
|
I think it should be ok like this |
|
Loons good on my end. Maybe we should add an iPad spec build line to the travis file so we're getting full test coverage? |
|
Also... Wondering if we should also optionally support |
|
This looks near done. I'm thinking we need mark's suggested travis ci spec change for this PR, and merge it. (Proper testing) love the arrow_directions add! |
|
Here are the arrow_direction option ;) |
|
Awesome! Thanks so much for this contribution! |
|
I think I'll merge this and solve the iPad tests issue in master real quick. :) |
|
Tests pass on iPad Air! |
|
👍 |
Relative to #11
This PR force the use of popover when on iPad.
I changed the functionality with the following
If you want to present your alert in :sheet style and you are on iPad, you have to provide the
:sourcefor the popover (either a UIView or a UIBarButtonItem)You can also provide a
:modaloption if you want the popover to be modal. This option is only available for iOS 8+.I have updated all tests to work on iPhone and iPad