Skip to content

Add a :popover options to present the alert from popover#11

Closed
bmichotte wants to merge 10 commits intoGantMan:masterfrom
bmichotte:popover
Closed

Add a :popover options to present the alert from popover#11
bmichotte wants to merge 10 commits intoGantMan:masterfrom
bmichotte:popover

Conversation

@bmichotte
Copy link
Copy Markdown
Contributor

Present the alert from a popover, by passing a :popover option and provide the source (either a UIView or a UIBarButtonItem)

rmq.append(UIButton, :my_button).on(:tap) do |sender|
  rmq.app.alert(title: "Actions!", message: "Alert from a Popover.", actions: [:ok, :cancel], popover: sender)
end

The popover stuff is ignored on iPhone.

@GantMan
Copy link
Copy Markdown
Owner

GantMan commented Jul 27, 2015

very cool! Can't wait to check this out. Does it work on iOS7 and iOS8?

@bmichotte
Copy link
Copy Markdown
Contributor Author

Yes, I made the modification for both

on :input and :secure. If not specified they default to ""
@GantMan
Copy link
Copy Markdown
Owner

GantMan commented Jul 29, 2015

busy week, will review soon.

@GantMan
Copy link
Copy Markdown
Owner

GantMan commented Jul 30, 2015

you should have the merge resolution in your repo as a PR.

@bmichotte bmichotte mentioned this pull request Jul 30, 2015
@bmichotte
Copy link
Copy Markdown
Contributor Author

I close this one, because of #17

@bmichotte bmichotte closed this Jul 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants