Pirate Translations #892
Merged
Pirate Translations #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pirates from Tower Structures were spawning with old or nonexistent translation tags. This fixes the spawners to spawn skeletons with the correct nbt.
- Bows and Swords given to the skeletons have proper translation tags, so death messages appear correctly
- Pirate Hats (and Turtle Helmets) given to the skeletons have proper translation tags (unnecessary cuz it's not visual, but it should be done for consistency)
- Pirates' names use translations instead of plain text
- Pirates' (default) names end with `§` to allow for future custom entity textures
|
Tested this in-game and checked out the nbt of the structures, all looking good. |
Bloo-dev
added
tested
github-actions bot
pushed a commit
that referenced
this pull request
Aug 10, 2023
* Pirate Translations
Pirates from Tower Structures were spawning with old or nonexistent translation tags. This fixes the spawners to spawn skeletons with the correct nbt.
- Bows and Swords given to the skeletons have proper translation tags, so death messages appear correctly
- Pirate Hats (and Turtle Helmets) given to the skeletons have proper translation tags (unnecessary cuz it's not visual, but it should be done for consistency)
- Pirates' names use translations instead of plain text
- Pirates' (default) names end with `§` to allow for future custom entity textures
* missed one set of names
* Convert single leftover pre-1.19 translate to new fallback format
---------
Co-authored-by: Bloo-dev <contact.bluefire610@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pirates from Tower Structures were spawning with old or nonexistent translation tags. This fixes the spawners to spawn skeletons with the correct nbt.
§to allow for future custom entity textures