Include MIR JSON files for Rust standard libs in SAW bindists #1868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanGlScott
force-pushed
the
T1859-bundle-rust-libs
branch
3 times, most recently
from
9df9fe0
to
c7006f7
Compare
29 tasks
When distributing SAW binaries, we want users to be able to turn their Rust code into MIR JSON with relatively minimal effort. To that end, this patch includes JSON files for the Rust standard libraries in SAW binary distributions so that users do not have to build this themselves. This mirrors how these files are included in `crux-mir` binary distributions. This checks off one box in #1859.
RyanGlScott
force-pushed
the
T1859-bundle-rust-libs
branch
from
c7006f7
to
4334531
Compare
|
One rather unfortunate aspect of this PR is that it adds about 7 additional minutes to each build job in order to build |
RyanGlScott
added
subsystem: crucible-mir
|
Still TODO:
|
RyanGlScott
added a commit
that referenced
this pull request
Sep 4, 2024
SAW's MIR backend requires a particular MIR JSON schema, but it is not entirely obvious which version of the JSON schema to use (#2111). This patch is one step towards addressing this concern. It: * Adds `mir-json` as a submodule. At present, nothing in the repo (CI or otherwise) actually _builds_ this submodule. Its presence is purely to communicate which version of `mir-json` must be used to compile Rust code to JSON that SAW can ingest. * Documents this in the `README`. In the future, we will want to actually build and use `mir-json` in the CI (see #1868 for an in-progress attempt at this), but in the meantime, this is a decent first step. Until we actually start building `mir-json` in the CI and using it, we will need to remember to bump the `mir-json` submodule each time that SAW's JSON schema requirement changes. Addresses one part of #2111.
RyanGlScott
added a commit
that referenced
this pull request
Sep 9, 2024
SAW's MIR backend requires a particular MIR JSON schema, but it is not entirely obvious which version of the JSON schema to use (#2111). This patch is one step towards addressing this concern. It: * Adds `mir-json` as a submodule. At present, nothing in the repo (CI or otherwise) actually _builds_ this submodule. Its presence is purely to communicate which version of `mir-json` must be used to compile Rust code to JSON that SAW can ingest. * Documents this in the `README`. In the future, we will want to actually build and use `mir-json` in the CI (see #1868 for an in-progress attempt at this), but in the meantime, this is a decent first step. Until we actually start building `mir-json` in the CI and using it, we will need to remember to bump the `mir-json` submodule each time that SAW's JSON schema requirement changes. Addresses one part of #2111.
RyanGlScott
added a commit
that referenced
this pull request
Sep 10, 2024
SAW's MIR backend requires a particular MIR JSON schema, but it is not entirely obvious which version of the JSON schema to use (#2111). This patch is one step towards addressing this concern. It: * Adds `mir-json` as a submodule. At present, nothing in the repo (CI or otherwise) actually _builds_ this submodule. Its presence is purely to communicate which version of `mir-json` must be used to compile Rust code to JSON that SAW can ingest. * Documents this in the `README`. In the future, we will want to actually build and use `mir-json` in the CI (see #1868 for an in-progress attempt at this), but in the meantime, this is a decent first step. Until we actually start building `mir-json` in the CI and using it, we will need to remember to bump the `mir-json` submodule each time that SAW's JSON schema requirement changes. Addresses one part of #2111.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When distributing SAW binaries, we want users to be able to turn their Rust code into MIR JSON with relatively minimal effort. To that end, this patch includes JSON files for the Rust standard libraries in SAW binary distributions so that users do not have to build this themselves. This mirrors how these files are included in
crux-mirbinary distributions.This checks off one box in #1859.