Initial CI build #62
Initial CI build #62
Conversation
langston-barrett
force-pushed
the
lb/ci
branch
8 times, most recently
from
3b7f74f to
fd82c45
Compare
langston-barrett
force-pushed
the
lb/ci
branch
from
fd82c45 to
c128dc4
Compare
| - name: Lint | ||
| run: cargo clippy | ||
|
|
||
| test: |
There was a problem hiding this comment.
Perhaps this should be named "build" instead of "test"? At present, this job doesn't run any tests.
| - name: Upload binary | ||
| uses: actions/upload-artifact@v3 | ||
| if: github.repository == 'GaloisInc/${{ env.NAME }}' | ||
| with: | ||
| name: "${{ env.NAME }}" | ||
| path: "target/release/${{ env.NAME }}" | ||
| if-no-files-found: error |
There was a problem hiding this comment.
Have you confirmed that the resulting binary is actually usable if the toolchain isn't installed?
| @@ -6,7 +6,7 @@ fn main() { | |||
| // Add the toolchain lib/ directory to `-L`. This fixes the linker error "cannot find | |||
| // -lLLVM-13-rust-1.60.0-nightly". | |||
| let out = Command::new("rustup") | |||
| .args(&["which", "rustc"]) | |||
| .args(["which", "rustc"]) | |||
There was a problem hiding this comment.
This is surprising. What motivated this change?
There was a problem hiding this comment.
Clippy! I can revert it if you prefer.
There was a problem hiding this comment.
Ah, right! Perhaps this belongs in a separate commit to make this clearer.
| run: | | ||
| rustup default nightly-2023-01-23 | ||
| rustup component add clippy rustc-dev | ||
| - uses: Swatinem/rust-cache@v2.7.0 |
There was a problem hiding this comment.
I wonder if we should configure the cache a bit more to make it behave like our typical Haskell GHA setups. After reading the rust-cache README a bit, I think we should tweak the following:
- I think we should enable
cache-on-failureso that build dependencies will still cache even if buildingmir-jsonitself fails. - To future-proof this a little bit in case we accidentally corrupt the cache and need to invalidate it, I think it would be worth setting
prefix-key: ${{ env.CACHE_VERSION }}, whereCACHE_VERSIONis a GHA environment variable.
Similarly for the use of rust-cache in the other job below.
Fixes #42