-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: Bump argo-client
, mypy
, cryptol
versions
#1809
Conversation
This brings in changes from Cryptol's constraint guards and FFI patches, which require some light code changes on SAW's end. These changes are mostly taken from #1751. Co-authored-by: Iavor Diatchki <iavor.diatchki@gmail.com>
ad087ca
to
801aa6c
Compare
When the CI invokes
The thing that baffles me is that right before this step, I specifically install Python 3.11, so I have no idea why |
801aa6c
to
0c46bf8
Compare
This patch: * Bumps the `mypy` lower bounds to avoid incurring a dependency on `typed-ast`, which is being EOL'd soon. See python/typed_ast#179. * Bumps the `argo` submodule to bring in the changes from GaloisInc/argo#195, which makes corresponding changes on the `argo` side. * Bumps the `cryptol` submodule to bring in the changes from GaloisInc/cryptol#1493, which makes the corresponding changes on the `cryptol` side.
0c46bf8
to
23cdc79
Compare
You are exactly right, @kquick. I've pushed a new version of the patch which changes Somewhat distressingly, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think not handling DForeign and DProp in SAW for the moment is OK.
I just wonder if error
is the right way to report these as I am not sure what's SAW's error reporting mechanism. We should make sure that if people use these features in a Cryptol spec and then try to use in SAW they get a normal error, rather than crashing.
Hah, I simply copied the Looking at the code, the existing convention appears to be that saw-script/cryptol-saw-core/src/Verifier/SAW/Cryptol.hs Lines 1751 to 1753 in 23cdc79
And
I could be wrong in this assessment, so please speak up if I am wrong here. |
That error-handling convention is what I'd expect (at least for existing code that isn't in |
This patch:
mypy
lower bounds to avoid incurring a dependency ontyped-ast
, which is being EOL'd soon. See typed_ast end of life (July 2023) python/typed_ast#179.argo
submodule to bring in the changes from Python: Avoidtyped-ast
dependency argo#195, which makes corresponding changes on theargo
side.cryptol
submodule to bring in the changes from Python: Bumpargo-client
,mypy
versions cryptol#1493, which makes the corresponding changes on thecryptol
side.