Python: Avoid typed-ast dependency
#195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanGlScott
force-pushed
the
cryptol-T1491
branch
2 times, most recently
from
6d75db7
to
d00a3a0
Compare
The `typed-ast` package is being end-of-life'd soon. See python/typed_ast#179. Moreover, it is causing issues when building with Python 3.11+. See GaloisInc/cryptol#1491. Thankfully, `typed-ast` is no longer required if you use sufficiently new versions of `mypy` and Python. This patch raises the lower version bounds to make it possible to shed the `typed-ast` dependency entirely.
RyanGlScott
force-pushed
the
cryptol-T1491
branch
from
d00a3a0
to
3e2996e
Compare
RyanGlScott
commented
Jan 26, 2023
| @@ -51,7 +51,7 @@ jobs: | |||
| poetry install | |||
| - name: Typecheck python code | |||
| working-directory: ./python | |||
| run: poetry run mypy argo_client | |||
| run: poetry run mypy --install-types --non-interactive argo_client | |||
There was a problem hiding this comment.
This change is a bit unfortunate, but perhaps unavoidable. mypy-0.900 do not install third-party libraries' type packages unless you explicitly opt in to it with --install-types. Moreover, I'm unclear if it's possible to make mypy always use --install-types as a pyproject.toml configuration option. At the very least, I can't find anything about this in the list of configuration options.
kquick
approved these changes
Jan 30, 2023
RyanGlScott
added a commit
to GaloisInc/cryptol
that referenced
this pull request
Jan 30, 2023
This patch: * Bumps the `mypy` lower bounds to avoid incurring a dependency on `typed-ast`, which is being EOL'd soon. See python/typed_ast#179. * Bumps the `argo` lower bounds to bring in the changes from GaloisInc/argo#195, which makes corresponding changes on the `argo` side. Fixes #1491.
RyanGlScott
added a commit
to GaloisInc/cryptol
that referenced
this pull request
Jan 30, 2023
This patch: * Bumps the `mypy` lower bounds to avoid incurring a dependency on `typed-ast`, which is being EOL'd soon. See python/typed_ast#179. * Bumps the `argo` lower bounds to bring in the changes from GaloisInc/argo#195, which makes corresponding changes on the `argo` side. Fixes #1491.
RyanGlScott
added a commit
to GaloisInc/cryptol
that referenced
this pull request
Jan 30, 2023
This patch: * Bumps the `mypy` lower bounds to avoid incurring a dependency on `typed-ast`, which is being EOL'd soon. See python/typed_ast#179. * Bumps the `argo` lower bounds to bring in the changes from GaloisInc/argo#195, which makes corresponding changes on the `argo` side. Fixes #1491.
RyanGlScott
added a commit
to GaloisInc/saw-script
that referenced
this pull request
Jan 30, 2023
This patch: * Bumps the `mypy` lower bounds to avoid incurring a dependency on `typed-ast`, which is being EOL'd soon. See python/typed_ast#179. * Bumps the `argo` submodule to bring in the changes from GaloisInc/argo#195, which makes corresponding changes on the `argo` side. * Bumps the `cryptol` submodule to bring in the changes from GaloisInc/cryptol#1493, which makes the corresponding changes on the `cryptol` side.
RyanGlScott
added a commit
to GaloisInc/saw-script
that referenced
this pull request
Jan 31, 2023
This patch: * Bumps the `mypy` lower bounds to avoid incurring a dependency on `typed-ast`, which is being EOL'd soon. See python/typed_ast#179. * Bumps the `argo` submodule to bring in the changes from GaloisInc/argo#195, which makes corresponding changes on the `argo` side. * Bumps the `cryptol` submodule to bring in the changes from GaloisInc/cryptol#1493, which makes the corresponding changes on the `cryptol` side.
RyanGlScott
added a commit
to GaloisInc/saw-script
that referenced
this pull request
Jan 31, 2023
This patch: * Bumps the `mypy` lower bounds to avoid incurring a dependency on `typed-ast`, which is being EOL'd soon. See python/typed_ast#179. * Bumps the `argo` submodule to bring in the changes from GaloisInc/argo#195, which makes corresponding changes on the `argo` side. * Bumps the `cryptol` submodule to bring in the changes from GaloisInc/cryptol#1493, which makes the corresponding changes on the `cryptol` side.
RyanGlScott
added a commit
to GaloisInc/saw-script
that referenced
this pull request
Jan 31, 2023
This patch: * Bumps the `mypy` lower bounds to avoid incurring a dependency on `typed-ast`, which is being EOL'd soon. See python/typed_ast#179. * Bumps the `argo` submodule to bring in the changes from GaloisInc/argo#195, which makes corresponding changes on the `argo` side. * Bumps the `cryptol` submodule to bring in the changes from GaloisInc/cryptol#1493, which makes the corresponding changes on the `cryptol` side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
typed-astpackage is being end-of-life'd soon. See python/typed_ast#179. Moreover, it is causing issues when building with Python 3.11+. See GaloisInc/cryptol#1491. Thankfully,typed-astis no longer required if you use sufficiently new versions ofmypyand Python. This patch raises the lower version bounds to make it possible to shed thetyped-astdependency entirely.