Add documentation to ML-KEM #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 1, 2024
mccleeary-galois
approved these changes
Oct 7, 2024
- Cryptography functions - Conversions between bits & bytes - Compression and decompression
All of section 4.3 (including 4.3.1)
marsella
force-pushed
the
135-update-mlkem
branch
from
7956934
to
0a41d52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of #135.
This adds documentation to all the parts of ML-KEM that are in the spec. It rearranges a few things as well, so might be easier to review commit-by-commit. I did not add additional documentation to the fast NTT version added in #95.
Remaining tasks on my part: I used this as a bit of an audit pass and have a big list of things that remain to bring this up to our gold standard. Rather than leave 135 as a giant long-term issue, I'm going to review those and consolidate them into a few smaller issues.
EDIT: This is done. See #144 #145 #146 #147 #148 #149