-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add easy-to-run KATs to ML-KEM #148
Labels
Comments
marsella
added a commit
that referenced
this issue
Oct 3, 2024
This brings module names into alignment with our standard (capitalized, matches the directory path, etc) and the directory structure in line with our recent changes (`Instantiations/` and `Tests/`)
marsella
added a commit
that referenced
this issue
Oct 3, 2024
marsella
added a commit
that referenced
this issue
Oct 3, 2024
marsella
added a commit
that referenced
this issue
Oct 3, 2024
marsella
added a commit
that referenced
this issue
Oct 3, 2024
Merged
marsella
added a commit
that referenced
this issue
Oct 4, 2024
This fixes files to be capitalized, removes an illegal dash, and adjusts things to sit in our newly established directory structure. Note that this does not build because the module names no longer match the file names.
marsella
added a commit
that referenced
this issue
Oct 4, 2024
This brings module names into alignment with our standard (capitalized, matches the directory path, etc) and the directory structure in line with our recent changes (`Instantiations/` and `Tests/`)
marsella
added a commit
that referenced
this issue
Oct 4, 2024
marsella
added a commit
that referenced
this issue
Oct 4, 2024
marsella
added a commit
that referenced
this issue
Oct 4, 2024
marsella
added a commit
that referenced
this issue
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are a bunch of small modifications we need to make to ML-KEM to bring it up to our gold standard (see e.g. #135 #144 #145 #146 #147). ML-KEM currently can be run against the KATs (see
kat.awk
) if you download one of thersp
files and run it against the implementation. However, for faster iteration it would be nice to have a smallerTests
section with a few of the KATs hard-coded, so we can quickly load and:check-docstrings
.There are not official KATs for the final draft yet, but there are some candidate KATs available to test with.
Instantiations/
directory forml_kem*.cry
and a separateTests/
directory -- seeCommon/EC/PrimeField/
for an example)The text was updated successfully, but these errors were encountered: