Added basic support for bare-metal ARM by adding pattern for finding binutils. #1921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arm-none-eabi in which_binutils()
|
This is a cleaner version of #1916. Two commits: one for the change and one for the CHANGELOG. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pwntools Pull Request
High Level Explanation
Added a pattern in
which_binutils()for finding bare-metal arm specific binutils. Previously, if this was installed but neither of the Linux ARM toolchain was not installed, then it wouldn't be able to find the utilities necessary for pwntools to work.Testing
From what I have seen, this didn't break any of the existing tests. I can create a new one if necessary.
Target Branch
The target branch for this will be
devas this is an enhancing the support forbare-metal ARM.