-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding pattern for looking up baremetal arm binutils #1916
Conversation
The reason why I added this was that pwntools couldn't find the packages from the apt package |
This needs a CHANGELOG addition |
…o fix ordering of issues in DEV
Changes to Dockerfile are not related to pull request.
Added the commit to Changelog. I am having issues undoing an accidental commit to the Dockerfile that I made. Is there a simple way to undo this? I can get my way around Git, but not a Git expert. |
Try |
@@ -199,6 +199,7 @@ def which_binutils(util): | |||
else: | |||
patterns = ['%s*linux*-%s' % (arch, gutil), | |||
'%s*-elf-%s' % (arch, gutil), | |||
'%s-none*-%s' % (arch, gutil), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if you have both packages installed? Does this break anything or it passes the tests? Also, IIRC bare-metal ARM can be compiled with any *arm*-gcc
with correct commandline flags, not only by arm-none-eabi-gcc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on what I have seen from my own testing (and manually tested), which_binutils() returns the first binutils that it recognizes. It will first find linux-gnueabi
then the linux-gnueabihf
. If those are not there then it tries to find none-eabi
. There seems to be no conflict.
Co-authored-by: Arusekk <arek_koz@o2.pl>
I am going to do another fork and add the changes there just to keep it simple. I am having difficulties fixing my mistakes with the commits. I will close this and create another pull request with just one/two commit. |
Updated pull request for this is numbered 1921 |
Pwntools Pull Request
This is an additioinal pattern so that baremetal arm (specifically arm-none-eabi) can be found by pwntools.
Testing
This was primarily tested through manual inspection. I ran the automated tests and it didn't break anything
Target Branch
I am putting this in dev for now; however, since it is a relatively simple one-line code, it could go into stable if desired.