Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LinearApolloSixFrameDisplay #560

Open
wants to merge 41 commits into
base: main
Choose a base branch
from
Open

Conversation

haessar
Copy link
Contributor

@haessar haessar commented Apr 2, 2025

Fixes #218

Main things to look out for are the drawHover logic, where individual CDS are determined from mouse position, and all other CDS belonging to the same parent mRNA are highlighted.

There is currently no dragging behaviour, and this is an open question. The equivalent view in Artemis doesn't allow dragging of the CDS features to alter them (it can be modified in a feature editor view instead). Should we therefore replicate this or adapt to allow dragging of the CDS?

Still need to fix tooltip on hover, and there is a TODO to fix the getFeatureLayoutPosition method.

Apollo3_issue_218

garrettjstevens and others added 30 commits January 7, 2025 00:19
…t still need to incorporate recent filter changes)
…t still need to incorporate recent filter changes)
haessar added 4 commits March 28, 2025 20:51
…nes belonging to a single transcript on hover.

Still need to fix various mouse events (e.g. dragging)
@haessar haessar requested a review from garrettjstevens April 2, 2025 13:05
@haessar haessar self-assigned this Apr 2, 2025
@haessar haessar marked this pull request as draft April 2, 2025 13:05
@haessar
Copy link
Contributor Author

haessar commented Apr 2, 2025

Fix six-frame display

@haessar
Copy link
Contributor Author

haessar commented Apr 2, 2025

Now fixed the tooltip bug.

@haessar
Copy link
Contributor Author

haessar commented Apr 2, 2025

Also fixed the getFeatureLayoutPosition method.

@haessar haessar marked this pull request as ready for review April 2, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move six-frame display to non-block-based rendering
2 participants