Closed
Conversation
najlkin
reviewed
Jan 30, 2026
Comment on lines
+98
to
+101
| void setOnKeyDown(SDL_Keycode key, KeyDelegate func) | ||
| { | ||
| onKeyDown[key] = [func](SDL_Keymod) { func(SDL_GetModState()); }; | ||
| } |
Contributor
There was a problem hiding this comment.
Why not to pass the argument there? There have been historically problems with SDL_GetModState(), I think.
Contributor
Author
There was a problem hiding this comment.
I tried, but it is clamped to KMOD_NONE (0).
Contributor
Author
There was a problem hiding this comment.
the SdlWindow::mouseEvents seems to use it too.
Contributor
There was a problem hiding this comment.
Well, with mouse it is easy, but with keys it is more complicated, because some layouts need modifiers for keys to be translated and then the modifier is removed. But worse, there has been some platform specific behavior of the function, I think 🤔 .
Contributor
Author
|
Closing for in-place solution in #336 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns the
KeyQPressedinto aKeyDelegateand add theWindow::SwitchSolution.