Conversation
tomstitt
approved these changes
Aug 26, 2021
Member
tomstitt
left a comment
tomstitt
left a comment
There was a problem hiding this comment.
Thank you @kanye-quest ! I was wondering if this could be the issue. We actually set this.canvas_.style.{width,height} at https://github.com/GLVis/glvis-js/blob/master/src/index.js#L61-L64 so if it's cleaner you could just store the unscaled sizes there and use them here
15 tasks
This was referenced Aug 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDL expects logical pixel dimensions for the window size i.e. not scaled by the device pixel ratio. So instead of passing in
canvas.widthandcanvas.heightwhich gives us an unwanted extra dpr scaling, we pass in the logical CSS dimensions.