Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 code style fixes #374

Merged
merged 43 commits into from
May 7, 2021
Merged

🧹 code style fixes #374

Changes from 1 commit
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
87eaa4b
fix code style issues in oshdb-api module
tyrasd Apr 29, 2021
dc4bdca
fix some code style issues in utils module
tyrasd Apr 29, 2021
0100852
harmonize code style of serializable functions module
tyrasd Apr 29, 2021
2b96e1c
first round checkstyle fix
rtroilo Apr 29, 2021
87ecd78
fix broken test
rtroilo Apr 29, 2021
da0ed1b
more checkstyle fixes
rtroilo May 4, 2021
112d2d3
fix some pmd warnings
rtroilo May 4, 2021
a6199fd
fix wrong javadoc
rtroilo May 4, 2021
dda88b4
fix a few "bug"s reported by sonarlint
tyrasd Apr 9, 2021
1163b21
fix a few "critical" code smells signalized by sonarlint
tyrasd Apr 9, 2021
5e3d5e1
fix a few "major" code smells signalized by sonarlint
tyrasd Apr 9, 2021
fe3bb01
fix a few "minor" code smells signalized by sonarlint
tyrasd Apr 9, 2021
2ced2c9
fix false-positive reported by sonarlint
tyrasd Apr 9, 2021
99160dd
this basically closes the result before it's returned
tyrasd Apr 9, 2021
9612fec
fix spotbug missing equals
rtroilo May 4, 2021
c64fc9f
spotbug, make osmentity serilazable
rtroilo May 4, 2021
5782a09
fix missing change
rtroilo May 4, 2021
ae3b07a
sonarcloud, fix new bugs
rtroilo May 4, 2021
ecec641
sonarcloud, fix new vulnerability
rtroilo May 4, 2021
c70201f
remove debugging lines
rtroilo May 4, 2021
2e4d9d4
sonarcloud, fix security hotspots
rtroilo May 4, 2021
5b201a9
sonarcloud, fix security hotspots
rtroilo May 4, 2021
20404c7
remove trailing whitespaces, +cs fixes
rtroilo May 5, 2021
c31a134
cs fix
rtroilo May 5, 2021
be11460
some more cs fixes
rtroilo May 5, 2021
7cb4a85
add deprecation info
rtroilo May 5, 2021
86f6c8d
fix simple sonarcloud bugs
rtroilo May 5, 2021
f072bb1
remove unused variables is TypeStartFinder
rtroilo May 6, 2021
6c78b60
remove trailing empty comment
rtroilo May 6, 2021
5e7ef75
some review fixes
rtroilo May 6, 2021
a0a8124
collapse more than 1 blank line
rtroilo May 6, 2021
8e4ef71
more review fixes
rtroilo May 6, 2021
6cbe06c
remove redudant exception
rtroilo May 6, 2021
427fbac
remove filenotfoundexception where it is possible
rtroilo May 6, 2021
4cd168e
fix spotbug severity=high warnings
rtroilo May 6, 2021
98f73c7
some spotbug trivial serverity=normal fixes
rtroilo May 6, 2021
5893aaf
remove printStacktraces
rtroilo May 6, 2021
7b17331
spotbug severity=high fixes
rtroilo May 6, 2021
b346e8a
fix failing build
rtroilo May 6, 2021
759bf3e
add to changelog
tyrasd May 5, 2021
ec1b598
make constants final and initialize them directly
tyrasd May 7, 2021
a11e660
Merge branch 'master' into checkstyle-oshdb-api
tyrasd May 7, 2021
dab466e
include toTimestamp for comparison
rtroilo May 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix wrong javadoc
  • Loading branch information
@rtroilo @tyrasd
rtroilo authored and tyrasd committed May 4, 2021
commit a6199fd5fb6c8a86aa1847d1efd17ec68aea4ceb
2 changes: 0 additions & 2 deletions oshdb/src/main/java/org/heigit/ohsome/oshdb/index/XYGrid.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,8 +163,6 @@ public long getId(double longitude, double latitude) {
*
* @param longitude Longitude in osm-coordinate system (long integer)
* @param latitude Latitude in osm-coordinate system (long integer)
*
* @see XYGrid.getId
*/
public long getId(long longitude, long latitude) {
// return -1, if point is outside geographical coordinate range
Expand Down