Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧹 code style fixes #374

Merged
merged 43 commits into from
May 7, 2021
Merged

🧹 code style fixes #374

merged 43 commits into from
May 7, 2021

Conversation

tyrasd
Copy link
Member

@tyrasd tyrasd commented Apr 29, 2021 •
edited
Loading

global code style clean up 🧹

Checklist

@tyrasd tyrasd added the code quality Related to our standards for 'good' code label Apr 29, 2021
@tyrasd tyrasd requested a review from rtroilo April 29, 2021 15:29
@tyrasd tyrasd changed the title code style improvements [oshdb-api] [oshdb-util] code style fixes (indents + misc) Apr 29, 2021
@tyrasd tyrasd force-pushed the checkstyle-oshdb-api branch from f01bbb9 to 2060990 Compare April 29, 2021 15:34
@tyrasd tyrasd changed the title [oshdb-api] [oshdb-util] code style fixes (indents + misc) code style fixes Apr 30, 2021
@tyrasd tyrasd changed the title code style fixes 🧹 code style fixes Apr 30, 2021
@tyrasd tyrasd changed the title 🧹 code style fixes 🧹 code style fixes Apr 30, 2021
@joker234 joker234 force-pushed the checkstyle-oshdb-api branch from 7a901bd to 112d2d3 Compare May 4, 2021 15:08
@tyrasd tyrasd force-pushed the checkstyle-oshdb-api branch from 99279a9 to a6199fd Compare May 4, 2021 15:40
@tyrasd tyrasd mentioned this pull request May 4, 2021
Closed
1 task
rtroilo
rtroilo previously approved these changes May 5, 2021
View reviewed changes
Copy link
Member

@rtroilo rtroilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment about OSHDBTimestampInterval.compareTo/equals.

tyrasd
tyrasd commented May 5, 2021
View reviewed changes
Copy link
Member Author

@tyrasd tyrasd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rtroilo , I looked through all changes and left (quite) some comments inline. In general it looks good, of course! 👍

@tyrasd tyrasd dismissed rtroilo’s stale review May 5, 2021 18:17

not ready yet :-P

@tyrasd tyrasd requested a review from rtroilo May 7, 2021 14:08
rtroilo
rtroilo approved these changes May 7, 2021
View reviewed changes
Copy link
Member

@rtroilo rtroilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tyrasd thank you for your effort.

@rtroilo rtroilo merged commit 4e59a5e into master May 7, 2021
@rtroilo rtroilo deleted the checkstyle-oshdb-api branch May 7, 2021 15:44
@tyrasd
Copy link
Member Author

tyrasd commented May 7, 2021

@tyrasd thank you for your effort.

you too 😘

@tyrasd tyrasd mentioned this pull request May 10, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtroilo rtroilo rtroilo approved these changes

Assignees
No one assigned
Labels
breaking This will introduce an incombability to previous versions. Documentation update compulsory code quality Related to our standards for 'good' code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tyrasd @rtroilo