Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - Location priority list for NNC #150

Closed
MeganCrowthers opened this issue Jun 25, 2021 · 19 comments
Closed

Feature Request - Location priority list for NNC #150

MeganCrowthers opened this issue Jun 25, 2021 · 19 comments
Assignees
Labels
1/2 Day time to complete issue enhancement New feature or request needs retesting North North Northants Issue Signed Off - North

Comments

@MeganCrowthers
Copy link
Contributor

User Story/Requirement
Norbert to only suppress the email forward if the bot is running in the West.

Is the feature request related to an existing problem? Please describe.
The fix would be to change the order at which we scan for locations depending on if it's WNC or NNC bot. The WNC is the as-is setup (Northampton, South Northants, Daventry, Wellingborough, Kettering, Corby, East Northants) the first area in the list which finds a match wins

Describe the solution you want to be used

Order for BOT to ascertain Sovereign (Provided by NNC)

• Wellingborough
• Kettering
• Corby
• East Northants
• South Northants
• Daventry
• Northampton

Describe alternatives you have considered
N/A

Additional comments
N/A

Acceptance Criteria*
Send an email referencing Eastfield as the location - confirm this sends to Wellingborough.

@MeganCrowthers MeganCrowthers added enhancement New feature or request North North Northants Issue labels Jun 25, 2021
@Sadie-hub
Copy link

Tested in UAT EMN709-EMN714 - All ok where town mentioned.
Tested 'Eastfield' EMN000715 - Still allocating to Northampton instead of Wellingborough

@Sadie-hub
Copy link

1/7 Re-tested 'Eastfield' EMN000716 - successfully allocated to Wellingborough

KevinWhite added a commit that referenced this issue Jul 7, 2021
@Sadie-hub
Copy link

Re tested in live EMN005370 - EMN005377 - all ok apart from EMN005374 which redirected to the West in error. The email text was 'Please can you advise me on waste in north Northamptonshire'
Is there anyway we can add the phrase 'North Northamptonshire' without Norby reading 'Northampton'?

@lfayter
Copy link

lfayter commented Jul 19, 2021

NNC - Raised a few additional test cases in Live:-
EMN005987 and 5989 - both directed correctly.
EMN005988 failed - using the wording 'north Northamptonshire', was incorrectly directed to WNC.

@lfayter
Copy link

lfayter commented Jul 20, 2021

NNC - I tried replicating EMN005988 in UAT but Norbert deals with it differently, it's moving the case to ALC (EMN000809) - which is better than it going to the West. I tried replicating it a further 4 times (810-813), slightly different wording, but each time it went to ALC.

@lfayter
Copy link

lfayter commented Jul 20, 2021

NNC - Retested in live to see if the case was dealt with the same as in UAT (see above update) - but it was sent to WNC again, the same as before (EMN006054).

@Sadie-hub Sadie-hub added the 1/2 Day time to complete issue label Aug 9, 2021
@lfayter
Copy link

lfayter commented Aug 9, 2021

Decision made that the process that currently happens in UAT will be moved over to live. Emails received that contain 'North Northamptonshire' will go to 'Awaiting Location Confirmation'. Confirmed on Teams also.

@lfayter
Copy link

lfayter commented Aug 11, 2021

NNC Live Testing:-
EMN007051 (2.24 pm) - Form submission - 'North Northamptonshire' specified within enquiry details. No address specified. Case went to ALC, replied to auto response with 'Kings Cliffe, North Northants'. Case went back to 'Hub-Awaiting Review'.

EMN007053 (2.37 pm) - Form submission - 'North Northamptonshire' specified within enquiry details. No address specified. Case went to ALC, replied to auto response with 'Kings Cliffe'. Case still went to 'Hub-Awaiting Review'

EMN007056 (3.06 pm) - Form submission - 'North Northamptonshire' specified within enquiry details. Bulwick address selected. Case allocated to correct sovereign council, email received. Case closed.

EMN007057 (3.21 pm) - Email submission - 'North Northamptonshire' specified within enquiry details. No address specified. Case went to ALC, replied to auto response with 'Bulwick'. Case allocated to correct sovereign council, email received. Case closed.

EMN007059 (3.34 pm) - Form submission - 'North Northamptonshire' specified within enquiry details. No address specified. Case went to ALC, replied to auto response with 'Bulwick'. Case allocated to correct sovereign council, email received. Case closed.

When it's a form submission, on the sovereign council email template we've noticed the original enquiry is not appearing on the email body. The update appears on the email, but you then have to click into the attachment to view the original enquiry. When it's an email submission, both the original enquiry and update appear on the email body of the sovereign council email template.

@lfayter
Copy link

lfayter commented Aug 11, 2021

Above testing took place yesterday, 9/8/21

@Sadie-hub
Copy link

Missing from Dynamo table:

  • Kings Cliffe
  • Laxton

Spelling mistake Brigstock

@MeganCrowthers
Copy link
Contributor Author

@Sadie-hub just to confirm what Areas as Kings Cliffe and Laxton and Brigstock in? Kettering, East Northants, Welly or Corby ?

@Sadie-hub
Copy link

@MeganCrowthers All East Northants

@MeganCrowthers
Copy link
Contributor Author

@Sadie-hub all done and ready for testing

@AndyBoatwright
Copy link

@lfayter the section re the enquiry details from forms and emails I've copied and pasted that off this bug and into the thread for #91 ; the reason is that its otherwise awkward to close bug/enhancement issues off if extra bits are included on the wrong one, plus we lose track of stuff if its been tagged on the wrong thread.

@lfayter
Copy link

lfayter commented Aug 17, 2021

NNC Live Testing - Tested Dynamo additions/amendments - Kings Cliffe, Laxton, Brigstock. All cases worked fine:-

Kings Cliffe - EMN007367 (form), EMN007385 (email)
Laxton - EMN007374 (form), EMN007386 (email)
Brigstock - EMN007373 (form), EMN007375 (email)

@MeganCrowthers
Copy link
Contributor Author

Fab - marked as Signed off and now live 😄

@MeganCrowthers
Copy link
Contributor Author

@lfayter sorry can you do same tests in live for me please - just to triple check its all working 😄

@lfayter
Copy link

lfayter commented Aug 17, 2021

NNC Live Testing:-
EMN007390 (form) - 'North Northamptonshire' mentioned in enquiry details. 'Laxton Road, Bulwick' selected as customer address. Correct sovereign council allocated, all emails received, case closed.
EMN007391 (email) - 'North Northamptonshire' mentioned in email body. 'Bulwick' specified in subject. Correct sovereign council allocated, all emails received, case closed.

@MeganCrowthers
Copy link
Contributor Author

Signed off from north

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1/2 Day time to complete issue enhancement New feature or request needs retesting North North Northants Issue Signed Off - North
Projects
None yet
Development

No branches or pull requests

4 participants