Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix radiation_transport example and add examples to CI #3532

Merged
merged 5 commits into from
Aug 14, 2024

Conversation

je-cook
Copy link
Contributor

@je-cook je-cook commented Aug 13, 2024

Description

Radiation max wall length was changed the wrong direction in magnitude in #3394 also the example was broken.
I've added the examples to the CI too since the process install action

Interface Changes

Checklist

I confirm that I have completed the following checks:

  • Tests run locally and pass pytest tests --reactor
  • Code quality checks run locally and pass pre-commit run --from-ref develop --to-ref HEAD
  • Documentation built locally and checked sphinx-build -W documentation/source documentation/build

@je-cook je-cook added bug Something isn't working radiation_transport Tasks relating to radiation transport labels Aug 13, 2024
@je-cook je-cook requested review from a team as code owners August 13, 2024 15:55
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.38%. Comparing base (2353a0b) to head (b249834).
Report is 43 commits behind head on develop.

Files with missing lines Patch % Lines
bluemira/base/parameter_frame/_frame.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3532   +/-   ##
========================================
  Coverage    76.38%   76.38%           
========================================
  Files          230      230           
  Lines        26640    26640           
========================================
  Hits         20349    20349           
  Misses        6291     6291           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Aug 13, 2024

⚠️ Warning Report

Found 0 new warnings, 0 fixed warnings. 🎉

All warnings (7)

On runtest

  • /home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ffcx/element_interface.py:23: DeprecationWarning: Use of elements created by UFL is deprecated. You should create elements directly using Basix.
  • /home/runner/work/bluemira/bluemira/bluemira/radiation_transport/radiation_tools.py:731: DeprecationWarning: interp2dis deprecated!interp2d` is deprecated in SciPy 1.10 and will be removed in SciPy 1.12.0.

For legacy code, nearly bug-for-bug compatible replacements are
RectBivariateSpline on regular grids, and bisplrep/bisplev for
scattered 2D data.

In new code, for regular grids use RegularGridInterpolator instead.
For scattered data, prefer LinearNDInterpolator or
CloughTocher2DInterpolator.

For more details see
https://gist.github.com/ev-br/8544371b40f414b7eaf3fe6217209bff
`

  • /home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ffcx/element_interface.py:26: DeprecationWarning: Converting elements created in UFL to Basix elements is deprecated. You should create the elements directly using basix.ufl.element instead
  • /home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/basix/ufl.py:1909: DeprecationWarning: Converting elements created in UFL to Basix elements is deprecated. You should create the elements directly using basix.ufl.element instead
  • /home/runner/work/bluemira/bluemira/bluemira/equilibria/optimisation/harmonics/harmonics_approx_functions.py:41: RuntimeWarning: divide by zero encountered in log10
  • /home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ufl/core/expr.py:275: DeprecationWarning: Expr.ufl_domain() is deprecated, please use extract_unique_domain(expr) instead.

On collect

  • /home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ufl/core/ufl_type.py:56: DeprecationWarning: attach_operators_from_hash_data deprecated, please use UFLObject instead.

@je-cook je-cook force-pushed the je-cook/fix_radaition_defaults branch from 840c2c9 to 41ac64c Compare August 14, 2024 12:47
Copy link

sonarcloud bot commented Aug 14, 2024

@oliverfunk oliverfunk merged commit 5052f20 into develop Aug 14, 2024
10 checks passed
@oliverfunk oliverfunk deleted the je-cook/fix_radaition_defaults branch August 14, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working radiation_transport Tasks relating to radiation transport
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants