Add radiation tools tests

[athoynilimanew]

Linked Issues

Description

Added tests for the following

• interpolated_field_values
• filtering_in_or_out
• pfr_filter
• make_wall_detectors
• FirstWallRadiationSolver

Interface Changes

Checklist

I confirm that I have completed the following checks:

• Tests run locally and pass pytest tests --reactor
• Code quality checks run locally and pass pre-commit run --from-ref develop --to-ref HEAD
• Documentation built locally and checked sphinx-build -W documentation/source documentation/build

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.36%. Comparing base (b1cf23b) to head (3aff10a).
Report is 57 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3394      +/-   ##
===========================================
- Coverage    74.57%   74.36%   -0.21%     
===========================================
  Files          231      231              
  Lines        26810    26810              
===========================================
- Hits         19993    19937      -56     
- Misses        6817     6873      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

⚠️ Warning Report

Found 0 new warnings, 0 fixed warnings. 🎉

All warnings (5)

On runtest

• /home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ffcx/element_interface.py:23: DeprecationWarning: Use of elements created by UFL is deprecated. You should create elements directly using Basix.
• /home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ffcx/element_interface.py:26: DeprecationWarning: Converting elements created in UFL to Basix elements is deprecated. You should create the elements directly using basix.ufl.element instead
• /home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/basix/ufl.py:1909: DeprecationWarning: Converting elements created in UFL to Basix elements is deprecated. You should create the elements directly using basix.ufl.element instead
• /home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ufl/core/expr.py:275: DeprecationWarning: Expr.ufl_domain() is deprecated, please use extract_unique_domain(expr) instead.

On collect

• /home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ufl/core/ufl_type.py:56: DeprecationWarning: attach_operators_from_hash_data deprecated, please use UFLObject instead.

[OceanNuclear]

A little comment/documentation would help but code-wise, this looks good :)

[je-cook]

I agree with @OceanNuclear's comment.

Also this doesnt close #3330, there are some more tests to be written specifically something that calls FirstWallRadiationSolver. It should be a very simple case with only a couple of detectors.

[athoynilimanew]

I agree with @OceanNuclear's comment.

Also this doesnt close #3330, there are some more tests to be written specifically something that calls FirstWallRadiationSolver. It should be a very simple case with only a couple of detectors.

Added test for FirstWallRadiationSolver (but the test requires a bit of time to run)

[je-cook]

Overall nearly there just the one comment, I've added a few customisations to the Solver to allow us to customise it to make the test quicker.

This will also need a rebase for the tests to pass because of unrelated bugs that are now fixes