Fix to incorrect PolyhedralPrismCurrentSource behaviour when inputted XS is in global not local coordinates #3188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3188 +/- ##
========================================
Coverage 80.45% 80.46%
========================================
Files 222 222
Lines 24640 24646 +6
========================================
+ Hits 19825 19831 +6
Misses 4815 4815 ☔ View full report in Codecov by Sentry. |
kj5248
force-pushed
the
jmatthews/3187-irregular-behaviour-of-polyhedralprismcurrentsource-cross-section-when-used-with-tf-pictureframe-circuits
branch
from
c7ea959
to
93b43c8
Compare
|
je-cook
approved these changes
Apr 25, 2024
je-cook
added
magnetostatics
je-cook
deleted the
jmatthews/3187-irregular-behaviour-of-polyhedralprismcurrentsource-cross-section-when-used-with-tf-pictureframe-circuits
branch
OceanNuclear
pushed a commit
that referenced
this pull request
Jun 17, 2024
… XS is in global not local coordinates (#3188) * fix to polycurrentsource XS when not local coords * updating of tests and adding new test * XS fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues
Closes #3187
Description
When XS coords were given that were not local ie centered around (0, 0, 0) the _calculate_points function tried to transform it to global resulting in incorrect geometry.
Fix
Made a change to behaviour such that XS centroid is calculated and if it doesn't match up with origin the XS is translated so it is. This means that the length of the shape is now measured from centroid rather than the midpoint. Additionally means it isn't possible to create a prism or circuit that is displaced from the origin, so if that is desired the origin has to be displaced instead.
Checklist
I confirm that I have completed the following checks:
pytest tests --reactorpre-commit run --from-ref develop --to-ref HEADsphinx-build -W documentation/source documentation/build