Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Irregular behaviour of polyhedralprismcurrentsource cross section when used with TF PictureFrame circuits #3187

Closed
kj5248 opened this issue Apr 16, 2024 · 0 comments · Fixed by #3188
Labels
bug Something isn't working magnetostatics Tasks relating to the magnetostatics module

Comments

@kj5248
Copy link
Contributor

kj5248 commented Apr 16, 2024

Describe the bug

When attempting to use ArbitraryPlanarPolyhedralXSCircuit for TF coils noticed weird behaviour of the winding pack position, however this didn't appear for other parameterisations such as PrincetonD. Tracked this problem through to the polyhedralprismcurrentsource class, specifically the _calculate_points function. As far as I could tell the issue was related to using _local_to_global on the cross section when the cross section coordinates were already located around the global center for the current source. Not sure why this only occurs sometimes, assumed it got missed in the tests due to only using cross sections which were around the origin.

First image below shows the intended prism, obtained by setting the XS coordinates to be centered around 0 whilst the second image is if the coordinates are centered around the shape center.

polyXSissue_fig1
polyXSissue_fig2

This could be solved by enforcing that the XS upon initialisation is in local coordinates or if not makes it so that it is. This could be done within the set cross section function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working magnetostatics Tasks relating to the magnetostatics module
Projects
None yet
1 participant