Bug fixes to parse learning rate from configs #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @rfriedman22 for finding and fixing this bug! :) Really appreciate your contribution. LGTM |
|
Glad I can help @kathyxchen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #167
What does this implement/fix? Explain your changes.
Fix parsing of configs file to check for
Noneinstead of"None". Also check for the edge case when learning rate is not specified at all, in which case, aValueErroris thrown.What testing did you do to verify the changes in this PR?
Read in
config_examples/train.ymland then callselene_sdk.utils.parse_configs_and_runas-is (i.e. no learning rate), with a learning rate added to the function arguments, or a learning rate added to the configs.