Fix a typo and documentation #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

kathyxchen merged 1 commit into FunctionLab:master from arlapin:arlapin/get_feature_list

Mar 26, 2021

Contributor

arlapin commented Mar 1, 2021

What does this implement/fix? Explain your changes.

The dictionary name is wrong.
The returned vector is always of size n_features, so the docstring is misleading.

What testing did you do to verify the changes in this PR?

Added unit tests


          Fix a typo and documentation

aede771

Contributor Author

arlapin commented Mar 1, 2021

PTAL @kathyxchen

Collaborator

kathyxchen commented Mar 26, 2021

LGTM! Thanks for this bugfix and for adding more tests! woohoo

kathyxchen merged commit 8cae211 into FunctionLab:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet