Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PixelDrawr: Investigate using WebGL #206

Open
JoshuaKGoldberg opened this issue Feb 20, 2017 · 2 comments
Open

PixelDrawr: Investigate using WebGL #206

JoshuaKGoldberg opened this issue Feb 20, 2017 · 2 comments
Labels
area: performance Improving the speed of games. difficult This is a hard issue. You'll want to get a few smaller ones done before trying it. package: pixeldrawr status: accepting prs Go ahead and send a pull request to resolve this issue!

Comments

@JoshuaKGoldberg
Copy link
Member

Upside: if done well, the game would probably be much more graphically performant.
Downside: technically much more detailed, and browser support might suffer.
@JoshuaKGoldberg JoshuaKGoldberg changed the title Consider using WebGL PixelDrawr: Investigate using WebGL Jul 12, 2020
@JoshuaKGoldberg JoshuaKGoldberg transferred this issue from FullScreenShenanigans/PixelDrawr Jul 12, 2020
@JoshuaKGoldberg JoshuaKGoldberg added difficult This is a hard issue. You'll want to get a few smaller ones done before trying it. package: pixeldrawr status: accepting prs Go ahead and send a pull request to resolve this issue! area: performance Improving the speed of games. labels Jul 12, 2020
@thadguidry
Copy link

Would integrating PixiJS be an option here?

@JoshuaKGoldberg
Copy link
Member Author

JoshuaKGoldberg commented Jan 23, 2022 •
edited
Loading

Hmm, good question @thadguidry! I'm leaning towards no for a couple of reasons:

  • EightBittr is roughly dependency-free as-it-is (it's really just React for the non-game UI, as I'm going to phase out MobX from UserWrappr soon)
  • PixiJS is awesome and powerful which means it has a lot of code that would be unused. https://bundlephobia.com/package/pixi.js@6.2.1 shows it as having quite a lot of kB of download time

I wouldn't object to an investigation that shows it being worth that extra size. But there are probably better issues to tackle sooner.

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Aug 22, 2022
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: performance Improving the speed of games. difficult This is a hard issue. You'll want to get a few smaller ones done before trying it. package: pixeldrawr status: accepting prs Go ahead and send a pull request to resolve this issue!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thadguidry @JoshuaKGoldberg