chore: Add docker-compose to run all services through docker - #440
Merged
Conversation
Contributor
Author
|
To be updated with latest changes after the merge of #444 |
CuriousLearner
marked this pull request as ready for review
September 14, 2022 12:05
CuriousLearner
changed the title
theskumar
requested changes
Sep 15, 2022
CuriousLearner
force-pushed
the
docker-setup
branch
from
September 15, 2022 10:39
c55e5a2 to
40a29f0
Compare
* main: fix(pyproject.toml): Add dependencies for mkdocs (Fueled#458) docs(README): Update docs to drop legacy poetry command (Fueled#457) fix(github-actions): Use poetry to install requirements & run tests (Fueled#456) docs(coding_rules): correct class names to be PascalCase (Fueled#455) ci(github-actions): ensure poetry is installed lint action (Fueled#453)
sahithchandan
approved these changes
Dec 5, 2022
sun337
reviewed
Dec 6, 2022
sun337
left a comment
sun337
left a comment
Contributor
There was a problem hiding this comment.
Didn't get to test, but LGTM.
|
|
||
| # Databases | ||
| # ============================== | ||
| # DATABASE_URL=postgres://username:password@yourhost.com:5432/database_name |
Contributor
There was a problem hiding this comment.
We could remove DATABASE_URL.
Contributor
Author
There was a problem hiding this comment.
Oh, this is a sample env file, so sample values here are okay. This is to guide people to replace them by actual values when they place an actual .env file.
Contributor
Author
|
Verified that it works. So, merging this in. If there are any other changes, we'll handle it is subsequent pull requests. Thank you everyone for their reviews & suggestions 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Different services require lot of local setup and tweaking to work on different OS. The goal of this PR is to containerize the service and present to easily run all services with help of docker-compose.
This would dockerize the setup and run services like django, postgres, celery, flower in separate containers.
None.