Skip to content

ci(github-actions): ensure poetry is installed lint action - #453

Merged
theskumar merged 1 commit into
Fueled:mainfrom
CuriousLearner:fix-github-actions
Sep 16, 2022
Merged

ci(github-actions): ensure poetry is installed lint action#453
theskumar merged 1 commit into
Fueled:mainfrom
CuriousLearner:fix-github-actions

Conversation

@CuriousLearner

Copy link
Copy Markdown
Contributor

Why was this change necessary?

make lint ran as part of CI/CD pipeline uses poetry to execute subsequent commands, but poetry is not installed -- which causes the pipeline to break.

How does it address the problem?

It installs poetry first, before running make lint to ensure everything works in CI/CD flow.

Are there any side effects?

None.

@theskumar theskumar changed the title fix(github-actions): Ensure to install poetry before lint action ci(github-actions): ensure poetry is installed lint action Sep 16, 2022
@theskumar
theskumar merged commit f19c80f into Fueled:main Sep 16, 2022
@theskumar
theskumar deleted the fix-github-actions branch September 16, 2022 09:03
theskumar added a commit that referenced this pull request Sep 16, 2022
* add-graphene:
  update post generate script to remove graphql files
  Minor comment fix
  Update docs to clarify GraphQL API endpoint
  move: graphql schema under graphql directory
  Move graphql to root
  Delete GraphQL docs if not chosen
  Delete all GraphQL related files if not chosen
  Add documentation
  update user service
  Add links to graphql docs
  rename add_graphene to add_graphql
  Add graphene, graphql api
  ci(github-actions): ensure poetry is installed lint action (#453)
  chore: make the relative and absolute imports consistent (#450)
  upgrade packages (#451)
theskumar added a commit that referenced this pull request Sep 16, 2022
* add-graphene:
  update post generate script to remove graphql files
  Minor comment fix
  Update docs to clarify GraphQL API endpoint
  move: graphql schema under graphql directory
  Move graphql to root
  Delete GraphQL docs if not chosen
  Delete all GraphQL related files if not chosen
  Add documentation
  update user service
  Add links to graphql docs
  rename add_graphene to add_graphql
  Add graphene, graphql api
  ci(github-actions): ensure poetry is installed lint action (#453)
  chore: make the relative and absolute imports consistent (#450)
  upgrade packages (#451)
CuriousLearner added a commit to CuriousLearner/django-init that referenced this pull request Dec 5, 2022
* main:
  fix(pyproject.toml): Add dependencies for mkdocs (Fueled#458)
  docs(README): Update docs to drop legacy poetry command (Fueled#457)
  fix(github-actions): Use poetry to install requirements & run tests (Fueled#456)
  docs(coding_rules): correct class names to be PascalCase (Fueled#455)
  ci(github-actions): ensure poetry is installed lint action (Fueled#453)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants