Skip to content

Conversation

@xunilrj
Copy link
Contributor

@xunilrj xunilrj commented Oct 29, 2025

Description

This PR continue #7391.

First, it removes some easy todo!() around ParsedDeclId. It seems only fn or struct are using those. But I decided to implement them anyway to keep the code uniform. We may be able to simplify this, I think.

Second, it implements coin analysis for const generics. Unfortunately, the analysis runs on the fn declaration and not on the materialised version. So even calling a function with 0 generates the error.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@xunilrj xunilrj requested a review from a team as a code owner October 29, 2025 14:18
@xunilrj xunilrj self-assigned this Oct 29, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 29, 2025

CodSpeed Performance Report

Merging #7473 will not alter performance

Comparing xunilrj/removing-const-generics-todos-2 (82959e3) with master (90c8ed2)

Summary

✅ 25 untouched

@xunilrj xunilrj requested a review from a team November 2, 2025 22:49
@xunilrj xunilrj force-pushed the xunilrj/removing-const-generics-todos-2 branch from 8145c1f to 82959e3 Compare November 5, 2025 09:28
@xunilrj xunilrj enabled auto-merge (squash) November 5, 2025 09:28
@xunilrj xunilrj merged commit 0316a50 into master Nov 5, 2025
46 checks passed
@xunilrj xunilrj deleted the xunilrj/removing-const-generics-todos-2 branch November 5, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants