Removing todo const generics #7391

xunilrj · 2025-09-16T00:50:01Z

Description

Continuation of #6860.

The summary of removed todo!() are:
1 - Some todo!() are actually unreachable. In future PRs I will try to model the AST better and remove these match arms;
2 - Some are trivial impls like spans;
3 - Some are trivial from traits like PartialEq and PartialOrd.

Others will be removed in future PRs.

Checklist

I have linked to any relevant issues.
I have commented my code, particularly in hard-to-understand areas.
I have updated the documentation where relevant (API docs, the reference, and the Sway book).
- If my change requires substantial documentation changes, I have requested support from the DevRel team
I have added tests that prove my fix is effective or that my feature works.
I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
I have requested a review from the relevant team or maintainers.

codspeed-hq · 2025-09-16T01:04:06Z

CodSpeed Performance Report

Merging #7391 will not alter performance

_{Comparing xunilrj/removing-todo-const-generics (3d7b1a1) with master (3c6f718)}

Summary

✅ 25 untouched

sway-lsp/src/traverse/typed_tree.rs

spam.

sway-core/src/control_flow_analysis/dead_code_analysis.rs

sway-core/src/ir_generation/function.rs

sway-core/src/language/ty/declaration/declaration.rs

sway-core/src/language/ty/expression/expression_variant.rs

sway-core/src/semantic_analysis/ast_node/expression/intrinsic_function.rs

sway-core/src/semantic_analysis/symbol_resolve.rs

sway-core/src/type_system/ast_elements/type_argument.rs

sway-core/src/type_system/ast_elements/type_parameter.rs

sway-core/src/type_system/info.rs

sway-lsp/src/capabilities/document_symbol.rs

sway-lsp/src/capabilities/inlay_hints.rs

sway-lsp/src/traverse/typed_tree.rs

JoshuaBatty

Thanks for addressing the unwrap issue! can we remove the remaining unwraps i've pointed out as well? Thanks

xunilrj · 2025-10-09T13:49:08Z

Thanks for addressing the unwrap issue! can we remove the remaining unwraps i've pointed out as well? Thanks

I created another PR to better address these unwrap. #7453
I still suggest that we merge this one first. As the other touches in a lot of more files.

Suggestions will be implemented by another PR.

## Description This PR is a continuation of #7391. It also changes from `GenericArgument` to `GenericTypeArgument`. The rationale is that `GenericArgument` should only be used where we can have types and const generics. And it a lot of cases, we only accept types. ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [ ] If my change requires substantial documentation changes, I have [requested support from the DevRel team](https://github.com/FuelLabs/devrel-requests/issues/new/choose) - [x] I have added tests that prove my fix is effective or that my feature works. - [ ] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [ ] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers.

## Description This PR continue #7391. First, it removes some easy `todo!()` around `ParsedDeclId`. It seems only `fn` or `struct` are using those. But I decided to implement them anyway to keep the code uniform. We may be able to simplify this, I think. Second, it implements coin analysis for const generics. Unfortunately, the analysis runs on the `fn` declaration and not on the materialised version. So even calling a function with `0` generates the error. ## Checklist - [x] I have linked to any relevant issues. - [ ] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [ ] If my change requires substantial documentation changes, I have [requested support from the DevRel team](https://github.com/FuelLabs/devrel-requests/issues/new/choose) - [x] I have added tests that prove my fix is effective or that my feature works. - [ ] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers.

xunilrj self-assigned this Sep 16, 2025

xunilrj temporarily deployed to fuel-sway-bot September 16, 2025 00:50 — with GitHub Actions Inactive

xunilrj force-pushed the xunilrj/removing-todo-const-generics branch from 27cbf5a to 8282f12 Compare September 25, 2025 18:33

xunilrj had a problem deploying to fuel-sway-bot September 25, 2025 18:33 — with GitHub Actions Error

xunilrj temporarily deployed to fuel-sway-bot September 25, 2025 18:37 — with GitHub Actions Inactive

xunilrj marked this pull request as ready for review September 25, 2025 19:03

xunilrj requested review from a team as code owners September 25, 2025 19:03

IGI-111 previously approved these changes Sep 26, 2025

View reviewed changes

IGI-111 temporarily deployed to fuel-sway-bot September 26, 2025 12:39 — with GitHub Actions Inactive

kmk142789 approved these changes Sep 28, 2025

View reviewed changes

JoshuaBatty temporarily deployed to fuel-sway-bot September 29, 2025 04:14 — with GitHub Actions Inactive

JoshuaBatty reviewed Sep 29, 2025

View reviewed changes

sway-lsp/src/traverse/typed_tree.rs Outdated Show resolved Hide resolved

xunilrj added 4 commits October 6, 2025 09:51

removing todos for const generics

03ae445

clippy and fmt issues

7c9ace5

fix typo

cb2a634

removing unwrap

b9ceaf4

xunilrj dismissed IGI-111’s stale review via b9ceaf4 October 6, 2025 12:54

xunilrj force-pushed the xunilrj/removing-todo-const-generics branch from ab94b9d to b9ceaf4 Compare October 6, 2025 12:54

xunilrj had a problem deploying to fuel-sway-bot October 6, 2025 12:54 — with GitHub Actions Error

This comment was marked as outdated.

Sign in to view

removing unwrap

2cf8478

xunilrj temporarily deployed to fuel-sway-bot October 6, 2025 12:57 — with GitHub Actions Inactive

xunilrj requested a review from JoshuaBatty October 7, 2025 01:49

ironcev requested changes Oct 7, 2025

View reviewed changes

better unreachable message

ee7b3de

xunilrj temporarily deployed to fuel-sway-bot October 7, 2025 23:05 — with GitHub Actions Inactive

This comment was marked as outdated.

Sign in to view

fix CI

01861c1

xunilrj temporarily deployed to fuel-sway-bot October 7, 2025 23:19 — with GitHub Actions Inactive

fmt and clippy issues

594ad42

xunilrj temporarily deployed to fuel-sway-bot October 7, 2025 23:28 — with GitHub Actions Inactive

xunilrj requested a review from ironcev October 7, 2025 23:35

ironcev approved these changes Oct 8, 2025

View reviewed changes

tritao approved these changes Oct 8, 2025

View reviewed changes