feat: typegen support for passing Uint8Array as Vec<u8>

[Dhaiwat10]

• Closes Should accept Uint8Array as Array / data or bytes type #1553

Release notes

In this release, we:

• Added typegen support for passing Uint8Array as Vec<u8

Summary

This PR improves typegen support for the u8 type by adding Uint8Array as a valid input type on the function signature alongside Vec<BigNumberish>.

Checklist

• I added — tests to prove my changes
• I updated — all the necessary docs
• I reviewed — the entire PR myself, using the GitHub UI
• I described — all breaking changes and the Migration Guide

[github-actions]

Coverage Report:

Lines	Branches	Functions	Statements
79.5%(+0%)	71.8%(+0%)	77.48%(+0%)	79.64%(+0%)

Changed Files:

Coverage values did not change👌.

[petertonysmith94]

I'm experiencing some type issues with the boolean inputs?

---

Would it be worthwhile to add similar tests for u16, u32, ...?

[petertonysmith94]

Suggested change

	const INPUT = [8, 6, 7, 5, 3, 0, 9];
	const INPUT_AS_UINT8_ARRAY = Uint8Array.from(INPUT);
	const INPUT: Vec<BigNumberish> = [8, 6, 7, 5, 3, 0, 9];
	const INPUT_AS_UINT8_ARRAY: Vec<BigNumberish> = Uint8Array.from(INPUT);

Is it worth adding the types here, to ensure they work as intended?

[Dhaiwat10]

@petertonysmith94 there's a separate issue for those types #2785, but I'm gonna be making changes to this PR regardless: #2884 (comment)

[nedsalk]

Handling the problem on the Vec common type level won't work because it'll affect other types, as well as outputs, which shouldn't be affected. This problem will have to be solved in a different manner, e.g. on the VectorType level or somewhere - I'm not sure where.

[nedsalk]

This will be a problem for u16 and u32 values because BigNumberish is used for them as well, but the Uint8Array cannot store their values and that is the reason why I created #2785. Users might get the false impression that they can pass Uint8Array for u16 and u32 vectors.

I think that this problem cannot be solved on the level of the generated types like this; rather, the checks must be done somewhere in typegen where abi type parsing is happening.

[nedsalk]

We are always returning a number[] here in runtime so this should never be Uint8Array. As mentioned above, this will have to be handled differently because the Vec type is shared between all vectors, both input and output ones.

[Dhaiwat10]

@nedsalk that's a great catch. I completely missed this.

I considered this deeper approach with changes deeper inside the Vec type but thought I might be able to get away with something quick like this. I will revert this PR and come back with a better approach that is more modular and flexible

[Dhaiwat10]

Closing since #1553 is not planned for now