Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Uint16Array for Vec<u16> and Uint32Array for Vec<u32> #2785

Open
nedsalk opened this issue Jul 18, 2024 · 0 comments
Open

Support Uint16Array for Vec<u16> and Uint32Array for Vec<u32> #2785

nedsalk opened this issue Jul 18, 2024 · 0 comments
Labels
feat Issue is a feature

Comments

@nedsalk
Copy link
Contributor

nedsalk commented Jul 18, 2024

#2018 and #2784 add support for Uint8Array to be passed where Vec<u8> is expected. We can extend that to support Uint16Array and Uint32Array as well.

Vec<u64> doesn't have a JavaScript equivalent so it'd still remain Vec<BigNumberish>. BigNumberish is defined as string | number | BN, but number only supports up to We might want to constrain Vec<u64> to string | BN because the maximum safe integer is less than u64. I'm not sure about this one, though, because people should know this info when dealing with large javascript numbers and it would be a breaking change. Still, I'm mentioning it for completeness.

@nedsalk nedsalk added feat Issue is a feature p2 labels Jul 18, 2024
@nedsalk nedsalk added this to the 0.x post-launch milestone Jul 18, 2024
@arboleya arboleya removed this from the 0.x post-launch milestone Jul 19, 2024
@arboleya arboleya removed the p2 label Aug 2, 2024
@arboleya arboleya modified the milestone: Caterpillar v1 Aug 2, 2024
@arboleya arboleya added temp-p2 and removed temp-M labels Sep 7, 2024
@arboleya arboleya added the temp:notion label Sep 8, 2024 — with Linear
@arboleya arboleya added the temp-linear label Sep 8, 2024 — with Linear
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Issue is a feature
Projects
None yet
Development

No branches or pull requests

2 participants